Skip to content

make OpenCV easyblock aware of protobuf, libwebp and OpenEXR dependencies provided via EasyBuild#2346

Merged
boegel merged 3 commits intoeasybuilders:developfrom
lexming:opencv-webp-openexr
Feb 24, 2021
Merged

make OpenCV easyblock aware of protobuf, libwebp and OpenEXR dependencies provided via EasyBuild#2346
boegel merged 3 commits intoeasybuilders:developfrom
lexming:opencv-webp-openexr

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Feb 24, 2021

Three changes:

  • OpenCV builds its own protobuf, it should only be done if protobuf is not a dependency, otherwise conflicts may arise between the two libraries of protobuf
  • Forces OpenCV to use external libwebp if declared as dependency
  • Forces OpenCV to use external OpenEXR if declared as dependency

@lexming lexming requested a review from verdurin February 24, 2021 09:31
@lexming lexming mentioned this pull request Feb 24, 2021
Merged
boegel
boegel requested changes Feb 24, 2021
View reviewed changes
Comment thread easybuild/easyblocks/o/opencv.py Outdated
@boegel boegel mentioned this pull request Feb 24, 2021
Closed
@boegel boegel changed the title add support for protobuf, libwebp and OpenEXR in OpenCV make OpenCV easyblock aware of protobuf, libwebp and OpenEXR dependencies provided via EasyBuild Feb 24, 2021
@boegel boegel added this to the next release (4.3.4?) milestone Feb 24, 2021
@lexming lexming mentioned this pull request Feb 24, 2021
Merged
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 24, 2021

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS OpenCV-4.2.0-foss-2020a-Python-3.8.2-contrib.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node376.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/7622dc4a847a798bdc4615d2d47bf013 for a full test report.

boegel
boegel approved these changes Feb 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 24, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenCV-4.2.0-fosscuda-2019b-Python-3.7.4.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3300.joltik.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/3bebfb4825c7535cea8c68f50aac4f20 for a full test report.

@boegel boegel merged commit d754f42 into easybuilders:develop Feb 24, 2021
@lexming lexming deleted the opencv-webp-openexr branch February 24, 2021 20:56
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 24, 2021

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS OpenCV-4.2.0-foss-2019b-Python-3.7.4.eb
  • SUCCESS OpenCV-4.0.1-foss-2018b-Python-3.6.6.eb
  • SUCCESS OpenCV-4.0.1-foss-2018b-Python-2.7.15.eb
  • SUCCESS OpenCV-3.4.7-foss-2019a-Python-3.7.2.eb
  • SUCCESS OpenCV-3.4.7-foss-2019a-Python-2.7.15.eb
  • SUCCESS OpenCV-3.4.5-foss-2018b-Python-2.7.15.eb
  • SUCCESS OpenCV-3.4.1-intel-2018a-Python-3.6.4.eb
  • SUCCESS OpenCV-3.4.1-foss-2018a-Python-3.6.4.eb

Build succeeded for 8 out of 8 (8 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/03e53f6bf2b0b0ffc585eb32af1f5812 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 25, 2021

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS OpenCV-4.2.0-fosscuda-2019b-Python-3.7.4.eb
  • SUCCESS OpenCV-3.4.7-fosscuda-2019a-Python-3.7.2.eb
  • SUCCESS OpenCV-3.4.7-fosscuda-2019a-Python-2.7.15.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node226.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2680 v4 @ 2.40GHz, Python 2.7.5
See https://gist.github.com/1ace4c285397014e01d314f3c0cdc1e8 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@verdurin verdurin Awaiting requested review from verdurin

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@lexming @boegel