Skip to content

{vis}[foss/2018a] opencv_contrib v3.4.1: rename and update to OpenCV v3.4.1 with contrib versionsuffix#12229

Merged
verdurin merged 2 commits intoeasybuilders:developfrom
lexming:20210222160535_new_pr_OpenCV341
Feb 25, 2021
Merged

{vis}[foss/2018a] opencv_contrib v3.4.1: rename and update to OpenCV v3.4.1 with contrib versionsuffix#12229
verdurin merged 2 commits intoeasybuilders:developfrom
lexming:20210222160535_new_pr_OpenCV341

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Feb 22, 2021 •
edited
Loading

(created using eb --new-pr)

opencv_contrib-3.4.1-foss-2018a-Python-3.6.4.eb provides both OpenCV and the extra modules from opencv_contrib. Therefore, it should use OpenCV as package name to disallow loading this easyconfig at the same time than any other OpenCV in this toolchain.

This PR renames it to OpenCV-3.4.1-foss-2018a-Python-3.6.4-contrib.eb, which provides an equivalent build to the old one:

  • uses the same sources
  • uses the same dependencies
  • changes name to OpenCV plus -contrib in versionsuffix
  • uses the opencv easyblock instead of CMakeMake

@lexming
rename and update opencv_contrib-3.4.1-foss-2018a-Python-3.6.4.eb to …
ee8cdae 
…OpenCV-3.4.1-foss-2018a-Python-3.6.4-contrib.eb
@lexming lexming added the update label Feb 22, 2021
@lexming lexming changed the title rename and update opencv_contrib-3.4.1-foss-2018a-Python-3.6.4.eb to OpenCV-3.4.1-foss-2018a-Python-3.6.4-contrib.eb {vis}[foss/2018a] opencv_contrib v3.4.1: rename and update to OpenCV v3.4.1 with contrib versionsuffix Feb 22, 2021
@boegelbot

This comment has been minimized.

Sign in to view
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 22, 2021

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/e03381870c4b0f3eca5d3f0ae6367c17 for a full test report.

@boegel boegel added the change label Feb 22, 2021
@boegel boegel added this to the release after 4.3.3 milestone Feb 22, 2021
boegel
boegel approved these changes Feb 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 24, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2637.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/c35104382683e2c889dcb45cbeb73518 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 24, 2021

Test report by @lexming
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2346
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/b52059e06efd6bb157891c657a4078da for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 24, 2021

Test report by @lexming
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2346
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node376.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/a72d90bda320dcc7e9cc2b3f3b22c82d for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Feb 25, 2021

Going in, thanks @lexming!

@verdurin verdurin merged commit 65b0d3a into easybuilders:develop Feb 25, 2021
@lexming lexming deleted the 20210222160535_new_pr_OpenCV341 branch February 26, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix change enhancement

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@lexming @boegelbot @boegel @verdurin