add custom easyblock for FlexiBLAS by boegel · Pull Request #2369 · easybuilders/easybuild-easyblocks

boegel · 2021-03-25T16:00:14Z

(created using eb --new-pr)

hound

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Flamefire

LGTM, only some minor Python changes. Add as a batch is easiest, if you agree (on the files tab)

add extra easyconfig parameters + include suggested changes

…ters

…t step, make sure that all backends are supported libraries

boegel · 2021-05-05T11:52:40Z

I need some feedback from the FlexiBLAS developers (like @grisuthedragon) on how to deal with MKL as a backend for FlexiBLAS, see mpimd-csc/flexiblas#16, but that shouldn't block this PR imho...

Co-authored-by: ocaisa <[email protected]>

boegel · 2021-05-11T08:21:59Z

This needs a little bit more work in order to make the FlexiBLAS tests pass when EasyBuild is configured to do RPATH linking, so don't merge just yet please :)

Flamefire · 2021-05-11T08:41:59Z

@boegel Github has the "convert to draft" button at the bottom which makes it impossible to merge :)

…linking

…easybuild-easyblocks into 20210325170009_new_pr_PPdKrfDcRM

…tory to compiler flags for test command

boegel · 2021-05-11T15:42:12Z

Last commit seems to work as expected on x86_64 when using eb --rpath, but not on POWER for some reason... Will dig further.

boegel · 2021-05-11T15:55:06Z

Ah, it works by accident because I had a full FlexiBLAS installation already in place, so the test binaries found libflexiblas.so.3 in there during the test step... 🤦

…ATH when running 'make test', which is used as a fallback even when using RPATH linking

ocaisa · 2021-05-11T17:49:17Z

Going in, thanks for the patience @boegel

custom easyblock for FlexiBLAS (WIP)

3bb0383

hound bot reviewed Mar 25, 2021

View reviewed changes

boegel mentioned this pull request Mar 25, 2021

{lib}[GCC/10.3.0] FlexiBLAS v3.0.4 on top of OpenBLAS 0.3.15 easybuilders/easybuild-easyconfigs#12476

Merged

2 tasks

boegel added the new label Mar 31, 2021

boegel added this to the 4.x milestone Mar 31, 2021

Flamefire previously approved these changes Apr 28, 2021

View reviewed changes

smoors reviewed Apr 29, 2021

View reviewed changes

Comment thread easybuild/easyblocks/f/flexiblas.py Outdated

Samuel Moors and others added 5 commits April 30, 2021 22:22

add extra easyconfig parameters + include suggested changes

2188f31

sort import order

07ac227

always check if the default blas lib is supported

80a3e2f

fix line too long

5c8793f

Merge pull request #39 from smoors/pr2369

fd76d5e

add extra easyconfig parameters + include suggested changes

boegel dismissed Flamefire’s stale review via fd76d5e May 4, 2021 13:19

Flamefire reviewed May 4, 2021

View reviewed changes

Comment thread easybuild/easyblocks/f/flexiblas.py Outdated

Flamefire reviewed May 4, 2021

View reviewed changes

Comment thread easybuild/easyblocks/f/flexiblas.py

boegel added 2 commits May 4, 2021 17:03

simplify defining configure options based on custom easyconfig parame…

28e6c19

…ters

strip out imkl stuff from FlexiBLAS easyblock for now, add custom tes…

5b52b6f

…t step, make sure that all backends are supported libraries

boegel changed the title ~~custom easyblock for FlexiBLAS (WIP)~~ custom easyblock for FlexiBLAS May 5, 2021

boegel changed the title ~~custom easyblock for FlexiBLAS~~ add custom easyblock for FlexiBLAS May 5, 2021

pick up (pre)testopts in test step in custom easyblock for FlexiBLAS

dd9f0f2

ocaisa reviewed May 7, 2021

View reviewed changes

Comment thread easybuild/easyblocks/f/flexiblas.py

fix typo in comment

eb34d16

Co-authored-by: ocaisa <[email protected]>

boegel added 2 commits May 11, 2021 15:31

make sure that test binaries find FlexiBLAS library when using RPATH …

b9bbf02

…linking

Merge branch '20210325170009_new_pr_PPdKrfDcRM' of github.com:boegel/…

ef9af15

…easybuild-easyblocks into 20210325170009_new_pr_PPdKrfDcRM

ocaisa reviewed May 11, 2021

View reviewed changes

Comment thread easybuild/easyblocks/f/flexiblas.py Outdated

only inject -rpath linker option for FlexiBLAS library in build direc…

c50bf2e

…tory to compiler flags for test command

boegel force-pushed the 20210325170009_new_pr_PPdKrfDcRM branch from 517dd19 to c50bf2e Compare May 11, 2021 15:38

add location of FlexiBLAS library in build directory to $LD_LIBRARY_P…

f8c4ed1

…ATH when running 'make test', which is used as a fallback even when using RPATH linking

boegel mentioned this pull request May 11, 2021

Use LD_LIBRARY_PATH over RPATH for build dir .so boegel/easybuild-easyblocks#40

Closed

ocaisa reviewed May 11, 2021

View reviewed changes

Comment thread easybuild/easyblocks/f/flexiblas.py Outdated

prepend export statement for $LD_LIBRARY_PATH to pretestopts

f637115

ocaisa approved these changes May 11, 2021

View reviewed changes

ocaisa merged commit 0ee5733 into easybuilders:develop May 11, 2021

boegel deleted the 20210325170009_new_pr_PPdKrfDcRM branch May 11, 2021 18:37

boegel modified the milestones: 4.x, next release (4.3.5?) May 11, 2021

Flamefire mentioned this pull request Feb 9, 2023

fix check configure option in FlexiBLAS easyblock #2886

Merged

Conversation

boegel commented Mar 25, 2021

Uh oh!

hound bot left a comment

Choose a reason for hiding this comment

Uh oh!

Flamefire left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

boegel commented May 5, 2021

Uh oh!

Uh oh!

boegel commented May 11, 2021

Uh oh!

Flamefire commented May 11, 2021

Uh oh!

Uh oh!

boegel commented May 11, 2021

Uh oh!

boegel commented May 11, 2021

Uh oh!

Uh oh!

ocaisa commented May 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants