Skip to content

fix check configure option in FlexiBLAS easyblock#2886

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:fix-flexiblas
Feb 15, 2023
Merged

fix check configure option in FlexiBLAS easyblock#2886
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:fix-flexiblas

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Feb 9, 2023

Only checking for key might match where it should not. Use the full "-Dkey=" as the search string.

@boegel Looks like you intended to do that but forgot to use the already defined opt in #2369

@Flamefire
Fix to check for existance of config option in FlexiBLAS
1d7fa62 
Only checking for `key` might match where it should not.
Use the full `"-Dkey="` as the search string.
@boegel boegel changed the title Fix to check for existance of config option in FlexiBLAS fix check configure option in FlexiBLAS easyblock Feb 15, 2023
@boegel boegel added the bug fix label Feb 15, 2023
@boegel boegel added this to the next release (4.7.1?) milestone Feb 15, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 15, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS FlexiBLAS-3.0.4-GCC-10.3.0.eb
  • SUCCESS FlexiBLAS-3.0.4-GCC-11.2.0.eb
  • SUCCESS FlexiBLAS-3.1.3-GCC-11.2.0.eb
  • SUCCESS FlexiBLAS-3.2.0-GCC-11.3.0.eb
  • SUCCESS FlexiBLAS-3.2.0-NVHPC-22.7-CUDA-11.7.0.eb
  • SUCCESS FlexiBLAS-3.2.1-GCC-12.2.0.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3113.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/ee1923eaa41b0c08155c6b0ccd08adba for a full test report.

boegel
boegel approved these changes Feb 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Flamefire, the intention was indeed to use opt rather than key for checking...

@boegel boegel merged commit ada378e into easybuilders:develop Feb 15, 2023
@Flamefire Flamefire deleted the fix-flexiblas branch February 15, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

2 participants

@Flamefire @boegel