Enhance BWA easyblock to copy includes and libraries#2417
Merged
ocaisa merged 6 commits intoeasybuilders:developfrom May 12, 2021
Merged
Enhance BWA easyblock to copy includes and libraries#2417ocaisa merged 6 commits intoeasybuilders:developfrom
ocaisa merged 6 commits intoeasybuilders:developfrom
Conversation
ocaisa
requested changes
May 11, 2021
Member
ocaisa
left a comment
There was a problem hiding this comment.
It would be good to add some additional checks in the sanity_check_step for (some of?) the new includes and libraries.
Member
|
Test report by @ocaisa Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
ocaisa
requested changes
May 12, 2021
Co-authored-by: ocaisa <[email protected]>
Member
|
Test report by @ocaisa Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
Member
|
Thanks @jfgrimm ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)libbwa.a is already built by the Makefile, this just copies the library and header files into the installdir.