Skip to content

add custom sanity check to AOMP easyblock#2464

Merged
smoors merged 4 commits intoeasybuilders:developfrom
nordmoen:aomp_sanity_checks
Jun 11, 2021
Merged

add custom sanity check to AOMP easyblock#2464
smoors merged 4 commits intoeasybuilders:developfrom
nordmoen:aomp_sanity_checks

Conversation

@nordmoen
Copy link
Copy Markdown
Contributor

@nordmoen nordmoen commented Jun 9, 2021

Moved sanity checks from easyconfig into easyblock. This change makes it easier to detect configuration changes such as the addition of CUDA.

Comment thread easybuild/easyblocks/a/aomp.py Outdated
@smoors smoors added this to the 4.x milestone Jun 10, 2021
@smoors smoors changed the title Aomp sanity checks add sanity_check_step for Aomp easyblock Jun 11, 2021
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors modified the milestones: 4.x, next release (4.4.1) Jun 11, 2021
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 11, 2021

Going in, thanks @nordmoen!

@smoors smoors merged commit 144cf00 into easybuilders:develop Jun 11, 2021
@boegel boegel changed the title add sanity_check_step for Aomp easyblock add custom sanity check to AOMP easyblock Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants