Skip to content

ignore exit code of pkg-config command in OpenSSL wrapper easyblock, since with pkgconf they exit with a non-zero exit code if the OS package is not installed#2736

Merged
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20220604202000_new_pr_openssl_wrapper
Jun 4, 2022
Merged

ignore exit code of pkg-config command in OpenSSL wrapper easyblock, since with pkgconf they exit with a non-zero exit code if the OS package is not installed#2736
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20220604202000_new_pr_openssl_wrapper

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 4, 2022

(created using eb --new-pr)

…since with pkgconf they exit with a non-zero exit code if the OS package is not installed
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 4, 2022

Tests in easybuilders/easybuild-easyconfigs#15616, since this is only needed when using pkgconf rather than pkg-config.

@boegel boegel modified the milestones: release after 4.5.5, 4.5.5 Jun 4, 2022
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 7b4fcb6 into easybuilders:develop Jun 4, 2022
@boegel boegel deleted the 20220604202000_new_pr_openssl_wrapper branch June 4, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants