switch from pkg-config to pkgconf as build dependency for OpenSSL wrapper easyconfigs by boegel · Pull Request #15616 · easybuilders/easybuild-easyconfigs

boegel · 2022-06-04T16:30:51Z

(created using eb --new-pr)

pkg-config fails to build in Fedora 35 for me, while pkgconf works fine...

requires:

ignore exit code of pkg-config command in OpenSSL wrapper easyblock, since with pkgconf they exit with a non-zero exit code if the OS package is not installed easybuild-easyblocks#2736

…pper easyconfigs

boegel · 2022-06-04T16:34:13Z

@boegelbot please test @ generoso

boegelbot · 2022-06-04T16:35:09Z

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15616 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15616 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 8653

Test results coming soon (I hope)...

Details

- notification for comment with ID 1146646078 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2022-06-04T16:37:56Z

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f5e8d849f53dab0186d22e5832fe4bf4 for a full test report.

boegel · 2022-06-04T17:02:55Z

Hmm, pkgconf produces a non-zero exit code if a package is not installed, while pkg-config does not...

$ module load pkg-config/0.29.2
$ pkg-config --print-requires libcrypto
$ echo $?
0

$ ml pkgconf/1.8.0
$ pkg-config --print-requires libcrypto
$ echo $?
1

boegel · 2022-06-04T18:33:48Z

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2736"

boegelbot · 2022-06-04T18:40:12Z

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15616 EB_ARGS="--include-easyblocks-from-pr 2736" /opt/software/slurm/bin/sbatch --job-name test_PR_15616 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 8655

Test results coming soon (I hope)...

Details

- notification for comment with ID 1146665334 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2022-06-04T18:43:28Z

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2736
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/285edfdfa9f36aad9d8334a15a4c47c8 for a full test report.

boegel · 2022-06-04T18:47:00Z

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2736
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2617.swalot.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/0216418e85a9728d12f5b374b853c307 for a full test report.

SebastianAchilles · 2022-06-04T18:47:41Z

@boegelbot please test @ jsc-zen2
EB_ARGS="--include-easyblocks-from-pr 2736"

boegel · 2022-06-04T18:49:18Z

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2736
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2617.swalot.os - Linux CentOS Linux 8.5.2111, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/13a8f082d16c1c943cf276ad6641cf96 for a full test report.

boegel · 2022-06-04T18:51:42Z

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2736
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2617.swalot.os - Linux Ubuntu 20.04.4 LTS (Focal Fossa), x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.8.10
See https://gist.github.com/cfbdf79da43544d18111f722b0e9d9a8 for a full test report.

boegelbot · 2022-06-04T18:52:08Z

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15616 EB_ARGS="--include-easyblocks-from-pr 2736" /opt/software/slurm/bin/sbatch --job-name test_PR_15616 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 1255

Test results coming soon (I hope)...

Details

- notification for comment with ID 1146667155 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegel · 2022-06-04T18:53:55Z

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2736
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2617.swalot.os - Linux openSUSE Leap 15.3, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.15
See https://gist.github.com/7b16527b30fd3cd6eca322784b8c8394 for a full test report.

boegel · 2022-06-04T18:54:10Z

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2736
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
node2617.swalot.os - Linux Fedora Linux 35 (Container Image), x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.10.2
See https://gist.github.com/b1c62c9edf236ea79af907639105cb61 for a full test report.

boegelbot · 2022-06-04T18:54:19Z

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2736
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/4437c846bd355ae12049db8d6a4c3458 for a full test report.

boegel · 2022-06-04T19:15:13Z

Test of OpenSSL-1.0.eb fails in Fedora 35 container, some issues with the config script requiring a Perl package that is not installed there...

I wouldn't let that block this PR though, since that failure has nothing to do with the changes being made here.

SebastianAchilles

lgtm

SebastianAchilles · 2022-06-04T19:29:53Z

Going in, thanks @boegel!

boegel · 2022-06-05T07:47:06Z

I overlooked an important detail for the pkgconf easyconfig using system toolchain: we need to make sure that it picks up on the pkg-config files in the OS, like we do in the pkg-config easyconfig (cfr. #13765)

Fixed in #15617

switch from pkg-config to pkgconf as build dependency for OpenSSL wra…

9f8700e

…pper easyconfigs

boegel added the update label Jun 4, 2022

boegel added this to the 4.x milestone Jun 4, 2022

boegel modified the milestones: 4.x, release after 4.5.5 Jun 4, 2022

boegel mentioned this pull request Jun 4, 2022

ignore exit code of pkg-config command in OpenSSL wrapper easyblock, since with pkgconf they exit with a non-zero exit code if the OS package is not installed easybuilders/easybuild-easyblocks#2736

Merged

boegel modified the milestones: release after 4.5.5, 4.5.5 Jun 4, 2022

SebastianAchilles approved these changes Jun 4, 2022

View reviewed changes

SebastianAchilles added the change label Jun 4, 2022

SebastianAchilles merged commit c7de416 into easybuilders:develop Jun 4, 2022

boegel deleted the 20220604183046_new_pr_OpenSSL10 branch June 4, 2022 19:32

boegel removed the update label Jun 4, 2022

boegel mentioned this pull request Jun 5, 2022

make sure that pkgconf built with system toolchain picks up on .pc files in default OS search paths #15617

Merged

Conversation

boegel commented Jun 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boegel commented Jun 4, 2022

Uh oh!

boegelbot commented Jun 4, 2022

Uh oh!

boegelbot commented Jun 4, 2022

Uh oh!

boegel commented Jun 4, 2022

Uh oh!

boegel commented Jun 4, 2022

Uh oh!

boegelbot commented Jun 4, 2022

Uh oh!

boegelbot commented Jun 4, 2022

Uh oh!

boegel commented Jun 4, 2022

Uh oh!

SebastianAchilles commented Jun 4, 2022

Uh oh!

boegel commented Jun 4, 2022

Uh oh!

boegel commented Jun 4, 2022

Uh oh!

boegelbot commented Jun 4, 2022

Uh oh!

boegel commented Jun 4, 2022

Uh oh!

boegel commented Jun 4, 2022

Uh oh!

boegelbot commented Jun 4, 2022

Uh oh!

boegel commented Jun 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SebastianAchilles left a comment

Choose a reason for hiding this comment

Uh oh!

SebastianAchilles commented Jun 4, 2022

Uh oh!

boegel commented Jun 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

boegel commented Jun 4, 2022 •

edited

Loading

boegel commented Jun 4, 2022 •

edited

Loading