Skip to content

enhance sanity check in GCC easyblock such that it also passes/works on OpenSuSE#365

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:gcc_sanity_check
Mar 28, 2014
Merged

enhance sanity check in GCC easyblock such that it also passes/works on OpenSuSE#365
boegel merged 3 commits intoeasybuilders:developfrom
boegel:gcc_sanity_check

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 25, 2014

No description provided.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 28, 2014

@wpoely86: please review?

@wpoely86
Copy link
Copy Markdown
Member

Looks good

Comment thread easybuild/easyblocks/g/gcc.py Outdated
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wpoely86: can you make the above line exactly the same as here (trailing ,, indent), to avoid conflicts when this PR or #379 are merged...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 28, 2014

Thanks for the reviewing @wpoely86!

boegel added a commit that referenced this pull request Mar 28, 2014
enhance sanity check in GCC easyblock such that it also passes/works on OpenSuSE
@boegel boegel merged commit b636374 into easybuilders:develop Mar 28, 2014
@boegel boegel deleted the gcc_sanity_check branch March 28, 2014 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants