Conversation
|
@wpoely86: same here, sync with develop please |
* develop: fix typo don't hardcode default values for extra options refactor to make all extra_options return a list of tuples rather than a dict, conform the framework v1.x API enhance unit tests to verify type of return value of extra_options() static method refactor extra_options in existing easyblocks fix unit tests after changes in framework fix unit tests after changes in framework fix defining tmp_logdir config setting imkl: small remark in sanity check imkl: updated sanity check imkl: make version check more correct Reworked after remarks imkl: some cleanup and added some libs to the sanity check imkl: install everything with version 11.1.1 IntelBase: allow to add lines to silent.cfg fix ordering in import line fix typo fix readline module specs in Modules/Setup.dist add sanity check for readline Conflicts: easybuild/easyblocks/g/gcc.py
|
Jenkins fails here because it needs easybuilders/easybuild-framework#895 |
There was a problem hiding this comment.
why not generalise this further, and allow passing a list:
'multilib': [None, "Build multilib gcc with specified targets", CUSTOM],There was a problem hiding this comment.
Because you need a glibc of every arch that you wanna build...
There was a problem hiding this comment.
So? Those may be provided as dependencies in the GCC easyconfig, how can you tell?
As long as the default doesn't change it's OK, imho...
There was a problem hiding this comment.
If we stick to x86-64-*-linux*, the only options are m64, m32 and mx32 (the last one is not being used to the best of my knowledge?).
Of course, if EB goes the for ARM, POWERPC, etc, then this list becomes quite long 😉
|
Jenkins please retest |
|
retest this please |
There was a problem hiding this comment.
and then make this error message:
msg = "Using multilib requires 32-bit glibc (install one of %s, depending on your OS)" % ', '.join(glibc_32bit)
self.log.error(msg)|
@boegel good to go |
There was a problem hiding this comment.
s/glibc-32bit/glibc-devel-32bit/
There was a problem hiding this comment.
hmm, hold, that's not enough to make the build work. diving deeper...
There was a problem hiding this comment.
@wpoely86: replace the last entry with gcc-c++-32, it seems like that's doing the trick
maybe add some documentation there too:
glibc_32bit = [
"glibc.i686", # RedHat-based
"libc6-dev-i386", # Debian, Ubuntu
"gcc-c++-32", # OpenSuSE, SLES
]also, note the version number in libc6-dev-i386, not sure how worried we should be about that...
solving that would require regex support in check_os_dependency...
There was a problem hiding this comment.
libc6 is not a problem. If they ever go to libc7 (not going to happen IMHO), this will be the least of our worries 😉
|
Merging in, tested on OpenSuSE, works like a charm. Thanks @wpoely86! |
No description provided.