Move OS dependency check to systemtools.py#895
Merged
boegel merged 5 commits intoeasybuilders:developfrom Mar 28, 2014
Merged
Conversation
Member
There was a problem hiding this comment.
this used to be a private method, so there's no need to deprecate it, just kick it out (it's consider internal API, it doesn't affect easyblocks)
Member
|
@wpoely86: small remark, otherwise good to go in imho |
Member
Author
|
@boegel I've changed some things, please have another look |
Member
|
@wpoely86: two more minor cleanup remarks, looks fine otherwise |
Member
Author
|
@boegel final version (I hope) with 'which' and limited 'locate' |
Member
There was a problem hiding this comment.
last remark: clean this up to
cmd = 'locate --regexp "/%s$"' % depI'm not quite sure why the dict is being used here, I really see no reason...
Member
Author
|
@boegel ready to go |
Member
|
Excellent, merging it in. Thanks @wpoely86! |
boegel
added a commit
that referenced
this pull request
Mar 28, 2014
Move OS dependency check to systemtools.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.