add custom easyblock for pocl#3978
Merged
jfgrimm merged 4 commits intoeasybuilders:developfrom Nov 28, 2025
Merged
Conversation
Micket
reviewed
Nov 7, 2025
…Make generic easyblock, set additional configure options, add custom sanity check
d3c301b to
7e01a68
Compare
jfgrimm
reviewed
Nov 27, 2025
Comment on lines
+75
to
+88
| else: | ||
| # cleanup of options being passed to CMakeNinja.configure_step | ||
| if orig_fail_on_error is None: | ||
| del kwargs['fail_on_error'] | ||
| else: | ||
| kwargs['fail_on_error'] = orig_fail_on_error | ||
|
|
||
| if orig_return_full_cmd_result is None: | ||
| del kwargs['return_full_cmd_result'] | ||
| else: | ||
| kwargs['return_full_cmd_result'] = orig_return_full_cmd_result | ||
|
|
||
| self.cfg.update('configopts', '-DLLC_HOST_CPU=native') | ||
| return CMakeNinja.configure_step(self, *args, **kwargs) |
Member
There was a problem hiding this comment.
I think it would be good to print a clear warning message, stating that the build failed without CPU auto-detection, and that this will be tried as a fallback
Member
jfgrimm
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)edit (by @boegel): use of
-DLLC_HOST_CPU=nativewas introduced inpocleasyconfigs here:-DLLC_HOST_CPU=nativeto avoid CPU auto-detection easybuild-easyconfigs#16246Always doing so is problematic though, see:
unknown target CPU 'native'withdevbio-naparieasyconfig easybuild-easyconfigs#24374So it should only be done when there's no other option (as implemented in this custom easyblock)
edit2: now requires:
CMakeNinjaeasyblock #3999CMakeMake.configure_stepto not fail on non-zero exit code of 'cmake' command and to return full result of 'cmake' shell command #4000