Skip to content

add options to CMakeMake.configure_step to not fail on non-zero exit code of 'cmake' command and to return full result of 'cmake' shell command#4000

Merged
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20251126190128_new_pr_cmakemake
Nov 27, 2025
Merged

add options to CMakeMake.configure_step to not fail on non-zero exit code of 'cmake' command and to return full result of 'cmake' shell command#4000
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20251126190128_new_pr_cmakemake

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 26, 2025

(created using eb --new-pr)

@boegel boegel changed the title add options to CMakeMake.configure_step to not fail on non-zero exit code of 'cmake' command and to return full result of 'cmake' shell command add options to CMakeMake.configure_step to not fail on non-zero exit code of 'cmake' command and to return full result of 'cmake' shell command Nov 26, 2025
@boegel boegel added this to the next release (5.2.0) milestone Nov 26, 2025
@boegel
add options to CMakeMake.configure_step to not fail on non-zero exit …
bea21c6 
…code of 'cmake' command and to return full result of 'cmake' shell command
@boegel boegel force-pushed the 20251126190128_new_pr_cmakemake branch from 21f64c1 to bea21c6 Compare November 26, 2025 18:07
@boegel boegel mentioned this pull request Nov 26, 2025
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 26, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="zlib-ng-2.2.5-GCCcore-14.3.0.eb --installpath /tmp/$USER/pr4000"

@boegelbot boegelbot mentioned this pull request Nov 26, 2025
Merged
@boegelbot
Copy link
Copy Markdown

boegelbot commented Nov 26, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=4000 EB_ARGS="zlib-ng-2.2.5-GCCcore-14.3.0.eb --installpath /tmp/$USER/pr4000" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_4000 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8926

Test results coming soon (I hope)...

Details

- notification for comment with ID 3582631273 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Nov 26, 2025

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS zlib-ng-2.2.5-GCCcore-14.3.0.eb

Build succeeded for 1 out of 1 (total: 1 min 58 secs) (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/d177a807a7e431296b927e39c2ca015f for a full test report.

@boegel boegel mentioned this pull request Nov 26, 2025
Closed
Micket
Micket approved these changes Nov 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Nov 27, 2025

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS json-fortran-9.0.5-GCC-14.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-icelake-build - Linux Rocky Linux 9.6, x86_64, Intel(R) Xeon(R) Silver 4316 CPU @ 2.30GHz, Python 3.9.21
See https://gist.github.com/Micket/64537c71153b387614164469a291aeb2 for a full test report.

@Micket Micket merged commit 294dfb7 into easybuilders:develop Nov 27, 2025
22 checks passed
@boegel boegel deleted the 20251126190128_new_pr_cmakemake branch November 27, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @Micket