Fix setting Python variables in TensorRT easyblock#4046
Fix setting Python variables in TensorRT easyblock#4046boegel merged 4 commits intoeasybuilders:developfrom
Conversation
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 4 mins 13 secs) (1 easyconfigs in total) |
|
Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 42 secs) (1 easyconfigs in total) |
This now accepts an `install_src` parameter to choose which package to install. This can be used to e.g. install wheels without duplicating the logic used to determine parameters such as `--no-build-isolation`.
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 2 mins 49 secs) (1 easyconfigs in total) |
3b59317 to
6a4dd61
Compare
|
I factored out the changes to PythonPackage to #4050 but kept them included here so they can be tested in conjunction with the TensorRT change and individually. |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (total: 6 mins 8 secs) (4 easyconfigs in total) |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 1 min 42 secs) (1 easyconfigs in total) edit: this was mainly to test easybuilders/easybuild-framework#5088 before merging it |
(created using
eb --new-pr)For installing Python packages
set_py_env_varsneeds to be called whichPythonPackagedoes in itsconfigure_stepTensorRTskips most steps which means installing the extension/wheels fails if the user environment has unexpected settings.We can further reduce duplication and chances for mistakes by using
compose_install_commandpassing the wheel as the location.Closes #4050
which is included here