Allow easier reuse of compose_install_command of PythonPackage, and add %(python)s template and default Python libdir in sanity check#4050
Closed
Flamefire wants to merge 2 commits intoeasybuilders:developfrom
Conversation
This now accepts an `install_src` parameter to choose which package to install. This can be used to e.g. install wheels without duplicating the logic used to determine parameters such as `--no-build-isolation`.
compose_install_command of PythonPackage, and add %(python)s template and default Python libdir in sanity checkcompose_install_command of PythonPackage, and add %(python)s template and default Python libdir in sanity check
Member
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (total: 6 mins 12 secs) (2 easyconfigs in total) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now accepts an
install_srcparameter to choose which package to install.This can be used to e.g. install wheels without duplicating the logic
used to determine parameters such as
--no-build-isolation.Additionally in the sanity check
%(python)scan be used which is populated AFTER potentially loading the module and determiningself.python_cmdwhich avoids failures in--sanity-check-onlywhere that might not yet be set.Similar it keeps the default sanity check dir even when
filesparameter is set further reducing duplication.For a use case see #4046 which includes this change