Skip to content

correctly disable parallel build for ATLAS#434

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:fix_atlas_nopar
Jul 8, 2014
Merged

correctly disable parallel build for ATLAS#434
boegel merged 2 commits intoeasybuilders:developfrom
boegel:fix_atlas_nopar

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jul 8, 2014

the set_parallellism method is moved and renamed as a part of easybuilders/easybuild-framework#953, since it's not considered to be part of the easyblocks API

This patch tweaks the ATLAS easyblock to properly disable a parallel build.

Comment thread easybuild/easyblocks/a/atlas.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message makes no sense 😉
Just drop it? if the parallel is already on 1, there is no issue. Only display the warning when it is needed?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 8, 2014

@wpoely86: fixed, pls recheck?

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Jul 8, 2014

@boegel Looks good

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 8, 2014

Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Jul 8, 2014
correctly disable parallel build for ATLAS
@boegel boegel merged commit c372b1b into easybuilders:develop Jul 8, 2014
@boegel boegel deleted the fix_atlas_nopar branch July 8, 2014 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants