Skip to content

support for hierarchical module naming schemes#953

Merged
boegel merged 107 commits intoeasybuilders:developfrom
boegel:fix_toolchain_modname_custom_nms
Jul 8, 2014
Merged

support for hierarchical module naming schemes#953
boegel merged 107 commits intoeasybuilders:developfrom
boegel:fix_toolchain_modname_custom_nms

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 20, 2014

@geimer: this should fix the problem that's blocking you right now

I might need to figure out one more thing w.r.t. the devel module name before this really works for you, I'm looking into that...

boegel added 21 commits June 20, 2014 12:09
@boegel
set module name for toolchain using correct det_full_module_name meth…
d2f91f6 
…od, to make it always work with custom module naming schemes
@boegel
take into account dummy toolchain for which no module name should be …
e76ae49 
…determined
@boegel
fix import in module_generator tests
25637a7
@boegel
don't redetermine module name for current toolchain
baff525
@boegel
give proper warning when robot isn't used while it's required
95dbdb4
@boegel
avoid infinite recursion if there's a KeyError in a custom module nam…
d9f8ef6 
…ing scheme
@boegel
support separation between module subdir and module name in module na…
57c4a83 
…ming scheme by extending API for custom module naming schemes
@boegel
always use full module name in easyblock.py
2e77262
@boegel
fix missing import
e7bada6
@boegel
fix uses of det_module_name in easyblock.py
715241a
@boegel
only check existence for a proper toolchain module name (i.e. a string)
5584ae2
@boegel
add support in module naming scheme API to specify list of extensions…
0ab3645 
… to $MODULEPATH, and generate prepend-paths statements in the module file for them
@boegel
use correct full path for $MODULEPATH extension statements
2be885e
@boegel
use full module names for list of dependencies in parsed easyconfig
5b4993e
@boegel
fixes in unit tests w.r.t. refactoring in framework modules
435c5ab
@boegel
use short module name, except when checking for dependency modules in…
afb9825 
… toolchain.py
@boegel
use full module name for toolchain rather than a partial one
9df4fa2
@boegel
both full and short module name are required for toolchain, only set …
215c774 
…them for non-dummy toolchains
@boegel
fix unit tests after internal API changes
c714c29
@boegel
cleanup in toolchain.py test module
e026240
@boegel
correct use of short/full module names
4d84568
@boegel boegel changed the title set module name for toolchain using correct det_full_module_name method, to make it always work with custom module naming schemes support for hierarchical module naming schemes Jun 21, 2014
fgeorgatos
fgeorgatos reviewed Jun 22, 2014
View reviewed changes
Comment thread easybuild/tools/module_naming_scheme/__init__.py Outdated
Copy link
Copy Markdown
Contributor

@fgeorgatos fgeorgatos Jun 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented out?

Copy link
Copy Markdown
Member Author

@boegel boegel Jun 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, should simply be removed

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 8, 2014

@stdweird: remarks fixed!

stdweird
stdweird reviewed Jul 8, 2014
View reviewed changes
Comment thread easybuild/framework/easyblock.py Outdated
Copy link
Copy Markdown
Contributor

@stdweird stdweird Jul 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it part of the API? otehrwise, get rid of it

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 8, 2014

remarks fixed (AGAIN :P)!

@stdweird
Copy link
Copy Markdown
Contributor

stdweird commented Jul 8, 2014

@boegel looks fine to me now

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 8, 2014

Jenkins: test this please

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 8, 2014

all lights green by Jenkins, @stdweird is happy, so going in

big thanks to @geimer for significantly contributing to this!

boegel added a commit that referenced this pull request Jul 8, 2014
@boegel
Merge pull request #953 from boegel/fix_toolchain_modname_custom_nms
beed1a8 
support for hierarchical module naming schemes
@boegel boegel merged commit beed1a8 into easybuilders:develop Jul 8, 2014
@boegel boegel deleted the fix_toolchain_modname_custom_nms branch July 8, 2014 16:38
@boegel boegel mentioned this pull request Jul 10, 2014
Closed
@boegel boegel mentioned this pull request Aug 8, 2014
Closed
@boegel boegel mentioned this pull request Mar 18, 2015
Merged
@boegel boegel mentioned this pull request Apr 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.14

Development

Successfully merging this pull request may close these issues.

5 participants

@boegel @fgeorgatos @hpcugentbot @stdweird @wpoely86