drop requirement for setuptools as runtime dependency#2836
Merged
akesandgren merged 10 commits intoeasybuilders:4.xfrom Apr 22, 2019
Merged
drop requirement for setuptools as runtime dependency#2836akesandgren merged 10 commits intoeasybuilders:4.xfrom
akesandgren merged 10 commits intoeasybuilders:4.xfrom
Conversation
…o define easybuild.* namespaces
…le naming schemes are found correctly
…asyBuild does not have a runtime dependency on setuptools
Contributor
|
Going in, thanks @boegel! |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptoolswas only required because of thepkg_resources.declare_namespacestatements that were used to declare the variouseasybuild.*(sub)namespaces.There's a replacement in the Python standard library however, being
__import__('pkgutil').extend_path, and it's even the recommend approach (see https://packaging.python.org/guides/packaging-namespace-packages/#pkgutil-style-namespace-packages).One side-effect is that the
__init__.pyfiles should only contain theextend_pathstatement, nothing else. Because of this, some things had to be moved, i.e.:DUMMY_TOOLCHAIN_NAMEandDUMMY_TOOLCHAIN_VERSIONconstants were moved fromeasybuild.tools.toolchaintoeasybuild.tools.toolchain.toolchainDEVEL_MODULE_SUFFIXconstant was moved fromeasybuild.tools.module_naming_schemetoeasybuild.tools.module_naming_scheme.mnsModuleNamingSchemeclass is no longer available from theeasybuild.tools.module_naming_schemenamespace, only from theeasybuild.tools.module_naming_scheme.mnsnamespace (cfr. changes in support for hierarchical module naming schemes #953)