stop trying to use setuptools.setup in setup.py, always use distutils.core.setup instead#2988
Merged
migueldiascosta merged 5 commits intoeasybuilders:developfrom Aug 29, 2019
Merged
Conversation
….core.setup instead
…ybuild-framework directory
Member
|
Going in, thanks @boegel! |
This was referenced Aug 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
setuptoolsinsetup.pyhas done more harm than good. It's frequently a cause of problems because of old/ancient versions being available in the OS, broken versions floating around everywhere, etc.One recent example is https://lists.ugent.be/wws/arc/easybuild/2019-08/msg00057.html
In addition, it yields little to no benefit over just installing with the
setupfunction fromdistutils.coreinstead.So, let's abolish the
setuptoolsrequirement fully, following no longer requiring it as a runtime dependency (cfr. #2836).(fixes #2941)