Skip to content

fix definition of $MKLROOT, should be set to 'mkl' subdir of install dir#576

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:fix_mklroot
Apr 9, 2015
Merged

fix definition of $MKLROOT, should be set to 'mkl' subdir of install dir#576
boegel merged 2 commits intoeasybuilders:developfrom
boegel:fix_mklroot

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 10, 2015

bug mentioned by @klust

in practice, this doesn't make too much of a difference for use of eb itself (w.r.t. use of $MKLROOT in easyblocks/easyconfigs), but the path is incorrect w.r.t. MKL Link Advisor

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/838/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 10, 2015

@wpoely86: thoughts on this?

@wpoely86
Copy link
Copy Markdown
Member

Well, I hope it doesn't break anything. It shouldn't but we've seen stranger shit.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 11, 2015

breaking stuff early in dev is fine ;)

I'll take a look where $MKLROOT is being (obviously) used, and retest those builds on top of this.

@boegel boegel mentioned this pull request Mar 11, 2015
8 tasks
@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/898/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 9, 2015

merged via #590

@boegel boegel deleted the fix_mklroot branch April 9, 2015 17:11
boegel added a commit to boegel/easybuild-easyblocks that referenced this pull request Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants