Skip to content

stop using $root to make easyblock compatible with module files in Lua syntax#590

Merged
boegel merged 11 commits intoeasybuilders:developfrom
boegel:no_more_root
Apr 9, 2015
Merged

stop using $root to make easyblock compatible with module files in Lua syntax#590
boegel merged 11 commits intoeasybuilders:developfrom
boegel:no_more_root

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 5, 2015

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/897/
Test PASSed.

@pforai
Copy link
Copy Markdown
Contributor

pforai commented Apr 5, 2015

👍 here as well!

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/899/
Test FAILed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 7, 2015

Jenkins: test this please

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/900/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 7, 2015

@wpoely86: can you give this a thorough review? should be fine to go in, but it's good to have someone else double-check

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/901/
Test PASSed.

Comment thread easybuild/easyblocks/o/openbabel.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.installdir,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, nice catch

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Apr 8, 2015

looks good

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/902/
Test PASSed.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/903/
Test PASSed.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/904/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 9, 2015

I've tested this thoroughly by rebuilding all existing easyconfigs with the following toolchains: goolf/1.4.10, ictce/5.3.0, intel/* and foss/*, + NWChem with ictce/4.1.13

eb can now generate Lua module files for all of those builds, hooray!

boegel added a commit that referenced this pull request Apr 9, 2015
stop using $root to make easyblock compatible with module files in Lua syntax
@boegel boegel merged commit b5b1ed3 into easybuilders:develop Apr 9, 2015
@boegel boegel deleted the no_more_root branch April 9, 2015 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants