Skip to content

take *all* Python lib dirs into account in PythonPackage easyblock#628

Merged
boegel merged 6 commits intoeasybuilders:developfrom
boegel:pylibdirs
Jun 16, 2015
Merged

take *all* Python lib dirs into account in PythonPackage easyblock#628
boegel merged 6 commits intoeasybuilders:developfrom
boegel:pylibdirs

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 15, 2015

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1021/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1021/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 15, 2015

@wpoely86: please review?

@wpoely86
Copy link
Copy Markdown
Member

looks fine I think

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1022/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1022/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1023/
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1023/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel changed the title keep *all* Python lib dirs into account in PythonPackage easyblock take *all* Python lib dirs into account in PythonPackage easyblock Jun 16, 2015
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 16, 2015

easybuilders/easybuild-framework#1300 is required for this to work correctly

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 16, 2015

I've (re)tested several Python packages on top of this, combined with easybuilders/easybuild-framework#1300 (which is merged in).

So: going in, thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Jun 16, 2015
take *all* Python lib dirs into account in PythonPackage easyblock
@boegel boegel merged commit 47ef77b into easybuilders:develop Jun 16, 2015
@boegel boegel deleted the pylibdirs branch June 16, 2015 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants