Skip to content

don't modify values of 'paths' list passed as argument to prepend_paths#1300

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:purify_prepend_paths
Jun 16, 2015
Merged

don't modify values of 'paths' list passed as argument to prepend_paths#1300
boegel merged 2 commits intoeasybuilders:developfrom
boegel:purify_prepend_paths

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 16, 2015

I ran into this issue when using the updated PythonPackage easyblock from easybuilders/easybuild-easyblocks#628....

@boegel boegel mentioned this pull request Jun 16, 2015
Merged
wpoely86
wpoely86 reviewed Jun 16, 2015
View reviewed changes
Comment thread easybuild/tools/module_generator.py
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Jun 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, we were changing the list while iterating over it? 👎

Copy link
Copy Markdown
Member Author

@boegel boegel Jun 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were updating elements in a list while iterating over it, which is OK

What's not OK is that we're modifying the list that is being passed to this method...

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jun 16, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1777/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1777/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 16, 2015

Going in, thanks @wpoely86 for the review!

boegel added a commit that referenced this pull request Jun 16, 2015
@boegel
Merge pull request #1300 from boegel/purify_prepend_paths
df7cb20 
don't modify values of 'paths' list passed as argument to prepend_paths
@boegel boegel merged commit df7cb20 into easybuilders:develop Jun 16, 2015
@boegel boegel deleted the purify_prepend_paths branch June 16, 2015 17:44
boegel added a commit to boegel/easybuild-framework that referenced this pull request Jul 2, 2015
@boegel
add support for *not* expanding relative paths in prepend_paths (+ ap…
b11d26e 
…ply easybuilders#1300 fix to ModuleGeneratorLua)
@boegel boegel mentioned this pull request Jul 2, 2015
Merged
@fgeorgatos fgeorgatos mentioned this pull request Jul 13, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @hpcugentbot @wpoely86