add support in PythonPackage for installing with easy_install + installing zipped eggs (REVIEW) by boegel · Pull Request #698 · easybuilders/easybuild-easyblocks

boegel · 2015-09-19T19:39:20Z

No description provided.

…lling zipped eggs

hpcugentbot · 2015-09-19T19:40:34Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1209/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-09-19T19:55:29Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1211/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

…kage

hpcugentbot · 2015-09-19T20:10:37Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1212/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-09-19T20:14:26Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1213/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-09-19T20:50:24Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1214/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

boegel · 2015-09-19T20:57:17Z

we need to add a . at the very end of the command...

hpcugentbot · 2015-09-19T21:27:01Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1215/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

boegel · 2015-09-19T22:00:59Z

TODO: make sure . is added at the end of the install commands being executed

boegel · 2015-10-12T14:52:10Z

Jenkinss: test this please

hpcugentbot · 2015-10-12T14:56:20Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1271/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

…syblocks

hpcugentbot · 2015-10-12T15:47:15Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1272/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

wpoely86 · 2015-10-12T15:57:08Z

why not add a space between the first two?

I could, but there's already a space at the end in extrapath; maybe removed it there and adding it here is clearer

wpoely86 · 2015-10-12T16:01:47Z

lgtm

hpcugentbot · 2015-10-12T16:02:33Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1273/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-10-12T16:08:40Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1274/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-10-12T16:11:52Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1275/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-10-12T16:21:44Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1276/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-10-12T16:24:28Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1277/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-10-12T16:26:42Z

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1278/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

…nstall defined

hpcugentbot · 2015-10-12T16:38:25Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1279/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

…in PythonPackage via compose_install_command method

hpcugentbot · 2015-10-12T16:59:45Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1280/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

wpoely86 · 2015-10-12T18:43:28Z

"Installing zipped eggs requires use_easy_install=True"

hpcugentbot · 2015-10-12T19:05:14Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1281/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-10-12T22:43:17Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1283/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-10-12T22:47:20Z

Going in, thanks for the review @wpoely86!

add support in PythonPackage for installing with easy_install + installing zipped eggs (REVIEW)

ocaisa · 2015-10-15T15:57:36Z

For me this is triggering

ERROR: Build of /usr/local/software/juropa3/Stage5/software/Core/EasyBuild/develop/easybuild-easyconfigs/easybuild/easyconfigs/g/GC3Pie/GC3Pie-2.4.2.eb failed (err: "build failed (first 300 chars): Use of unknown easyconfig parameter 'use_easy_install' when getting parameter value")

Did you miss including the parameter in the easyconfig defaults?

boegel · 2015-10-15T16:54:09Z

@ocaisa: do you have a some more context? In which step did this error occur?

boegel · 2015-10-15T16:57:11Z

@ocaisa: this may be the culprit... If we use the below, you shouldn't run into the problem you're having.

if not self.cfg.get('use_easy_install', None):

The problem is that use_easy_install is not a general easyconfig parameter, but one specific to PythonPackage.

Although, even with that in mind, this line should never yield the error you're seeing...

Can you provide a full (debug) log?

add support in PythonPackage for installing with easy_install + insta…

e00260c

…lling zipped eggs

use self.install_cmd in VersionIndependentPythonPackage

db6cf36

use different options for easy_install in VersionIndependentPythonPac…

d5f2d91

…kage

use 'easy_install .'

1dd2c2e

use 'easy_install .' in VersionIndependentPythonPackage

a9a0fa9

boegel changed the title ~~add support in PythonPackage for installing with easy_install + installing zipped eggs~~ add support in PythonPackage for installing with easy_install + installing zipped eggs (WIP) Sep 19, 2015

boegel reviewed Sep 19, 2015
View reviewed changes

include --no-deps

e91a6c6

boegel reviewed Sep 19, 2015
View reviewed changes

boegel added this to the v2.4.0 milestone Sep 22, 2015

boegel mentioned this pull request Oct 7, 2015

easyconfigs for hod 3.0, incl. 'minimal' install that works with system Python hpcugent/hanythingondemand#94

Closed

boegel added 2 commits October 12, 2015 17:22

Merge branch 'develop' into easy_install

54b93bb

fix issues with extra_options in CMakePythonPackage and EB_libxml2 ea…

3fe53e9

…syblocks

wpoely86 reviewed Oct 12, 2015
View reviewed changes

debug broken test

058f07d

moar debugging

8c85eab

fix signature of extra_options in EB_libxml2

379b114

moar printing

cd4a7a5

return via PythonPackage

9e70cd3

MOAR printing

daa063c

make PythonPackage robust against not having zipped_egg or use_easy_i…

5cd4bd3

…nstall defined

add '.' at the end of easy_install commands, compose install command …

c8de3df

…in PythonPackage via compose_install_command method

boegel changed the title ~~add support in PythonPackage for installing with easy_install + installing zipped eggs (WIP)~~ add support in PythonPackage for installing with easy_install + installing zipped eggs (REVIEW) Oct 12, 2015

fix typo

8df8cc9

wpoely86 reviewed Oct 12, 2015
View reviewed changes

fix remarks

f13c17c

use EASY_INSTALL_CMD all the way

af02521

boegel added a commit that referenced this pull request Oct 12, 2015

Merge pull request #698 from boegel/easy_install

ce7827a

add support in PythonPackage for installing with easy_install + installing zipped eggs (REVIEW)

boegel merged commit ce7827a into easybuilders:develop Oct 12, 2015

boegel deleted the easy_install branch October 12, 2015 22:47

boegel reviewed Oct 15, 2015
View reviewed changes

boegel mentioned this pull request Oct 15, 2015

be more careful with checking 'use_easy_install' in PythonPackage.build_step #715

Merged

boegel mentioned this pull request Mar 16, 2016

fix test_step in UFC easyblock #872

Merged

Conversation

boegel commented Sep 19, 2015

Uh oh!

hpcugentbot commented Sep 19, 2015

Uh oh!

hpcugentbot commented Sep 19, 2015

Uh oh!

hpcugentbot commented Sep 19, 2015

Uh oh!

hpcugentbot commented Sep 19, 2015

Uh oh!

hpcugentbot commented Sep 19, 2015

Uh oh!

boegel Sep 19, 2015

Choose a reason for hiding this comment

Uh oh!

hpcugentbot commented Sep 19, 2015

Uh oh!

boegel Sep 19, 2015

Choose a reason for hiding this comment

Uh oh!

boegel commented Oct 12, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

wpoely86 Oct 12, 2015

Choose a reason for hiding this comment

Uh oh!

boegel Oct 12, 2015

Choose a reason for hiding this comment

Uh oh!

wpoely86 commented Oct 12, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

wpoely86 Oct 12, 2015

Choose a reason for hiding this comment

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

boegel commented Oct 12, 2015

Uh oh!

ocaisa commented Oct 15, 2015

Uh oh!

boegel commented Oct 15, 2015

Uh oh!

boegel Oct 15, 2015

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants