fix test_step in UFC easyblock#872
Merged
boegel merged 1 commit intoeasybuilders:developfrom Mar 16, 2016
Merged
Conversation
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1854/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Contributor
|
The comment says it wants a string value. Should this return |
Member
Author
|
No, one of the superclasses excepts a string value for the |
Contributor
|
Then it seems good. |
Member
Author
|
This fixes the installing UFC and FFC on top, so well worth merging. |
Member
Author
|
Thanks for the review @ehiggs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the UFC easyblock has been broken for a while (since #698 got merged), but this was not considered a big issue since UFC is deprecated (cfr. https://bitbucket.org/fenics-project/ufc-deprecated)
however, since the fix is pretty trivial...