Add an option to skip the sanitizer tests of Clang#806
Add an option to skip the sanitizer tests of Clang#806boegel merged 3 commits intoeasybuilders:developfrom
Conversation
These sanitizer tests often fail on HPC systems due to the 'weird' evironment. It doesn't neccessarily mean that they don't work (they usually do).
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1588/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
use this below instead:
if (disable_san_tests or self.cfg['skip_sanitizer_tests']) and build_option('strict') != run.ERROR:
self.log.debug("Disabling the sanitizer tests")
self.disable_sanitizer_tests()|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1589/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1590/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
enable by default, to avoid people tripping over this?
I would also mention the error you may run into in the description (take them from the EB ML post), for easy googling... ;-)
There was a problem hiding this comment.
Why, these test should be run. It's only on specific systems that it fails.
There was a problem hiding this comment.
OK, fine.
Can you copy-paste the error messages in the PR description? I'll merge this in then.
There was a problem hiding this comment.
Which error messages? Some sanitizer test can fail, but which one is random. It will only tell you test X, Y, ... have failed
Add an option to skip the sanitizer tests of Clang
These sanitizer tests often fail on HPC systems due to the 'weird'
evironment. It doesn't neccessarily mean that they don't work (they
usually do).
@boegel please review