Update easyblocks for MPICH and MVAPICH2 by besserox · Pull Request #844 · easybuilders/easybuild-easyblocks

besserox · 2016-02-29T14:50:12Z

MVAPICH2 library names have changed since version 2.1.
These changes in the library names are inherited from MPICH 3.1.1 and above.
cf http://git.mpich.org/mpich.git/blob_plain/v3.1.1:/CHANGES

… what the MPICH configure expects. MVAPICH2 now inherents from that easyblock instead of ConfigureMake

…locks into mpich_derivatives_easyblocks Conflicts: easybuild/easyblocks/m/mvapich2.py

MVAPICH2 library names have changed since version 2.1. These changes in the library names are inherited from MPICH 3.1.1 and above. cf http://git.mpich.org/mpich.git/blob_plain/v3.1.1:/CHANGES

hpcugentbot · 2016-02-29T14:50:14Z

Automatic reply from Jenkins: Can I test this?

boegel · 2016-02-29T18:58:10Z

Jenkins: ok to test

boegel · 2016-02-29T18:59:31Z

hmm, this is going to conflict nicely with #818...

@damianam: thoughts?

hpcugentbot · 2016-02-29T19:26:51Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1722/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

besserox · 2016-02-29T20:26:05Z

Thanks for pointing this out.
I will test #818 and see if I can add these sanity check on top of it.

…sybuild-easyblocks into mvapich2 Fixed conflicts in easybuild/easyblocks/m/mvapich2.py

damianam · 2016-03-01T11:58:21Z

@boegel I still have to get the list of files to be checked by MVAPICH2, MPICH and ParaStationMPI. I think it makes sense to merge this first, and then I will update my PR accordingly. Does it make sense?

boegel · 2016-03-01T12:10:59Z

+                                      for y in ['%s.a' % x, '%s.%s' % (x, shlib_ext)]]
+        else:
+            libraries = ['lib/lib%s' % y for x in ['mpi', 'mpicxx', 'mpifort']
+                                      for y in ['%s.a' % x, '%s.%s' % (x, shlib_ext)]]


repeating the list comprehension feels a bit bloated, since only the library names are different

cleaned up version proposed in besserox#2

boegel · 2016-03-01T12:11:13Z

@damianam: ok, makes sense, thanks for the feedback

This also properly detects changes in libraries names depending on MPICH or MVAPICH2 version

This was already the default behavior, just force it as the sanity check except them.

boegel · 2016-03-01T14:21:07Z

I tested this easyblock (with besserox#2 included) with all existing MVAPICH2 easyconfigs + the new ones available from easybuilders/easybuild-easyconfigs#2589, works like a charm.

Let's get this merged @besserox?

hpcugentbot · 2016-03-01T16:45:07Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1726/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

…n MPICH and MVAPICH2 easyblocks

hpcugentbot · 2016-03-01T17:34:25Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1727/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

besserox · 2016-03-01T17:35:59Z

I have updated this branch:

MPICH derivatives easyblocks #818 is merged into my branch. Thanks @damianam !
The sanity checks have been updated and moved to the MPICH easyblock
I have applied the changes suggested in style fixes in updated MVAPICH2 sanity check besserox/easybuild-easyblocks#2 manually (because now they apply to the MPICH easyblock)
I have moved some configuration options from MVAPICH to MPICH
I have added a use_new_libnames() member function in the MPICH easyblock to tell if the new library names are used or not. This function then can be overridden in derived class, eg for MVAPICH2.

boegel · 2016-03-01T17:56:10Z

@besserox: Thank you for the effort!

Frankly, it may have been easier to just get your original PR merged, and then rework #818 based on that, but we can make this work too... :-)

The thing is that @damianam is working on some changes on top of #818 (mostly w.r.t. the sanity checks), so he'll have to look into that on top of this PR now. Please ack @damianam?

W.r.t. use_new_libnames, I would take a different approach, rather than introduce a custom method. Let me get back to you with a suggestion there.

damianam · 2016-03-01T18:01:29Z

@boegel yes, I was working on that and had it mostly done. But it doesn't matter (see below).

In my PR we used the MPICH easyblock for psmpi. The approach of this PR affects in these points:

psmpi doesn't build mpiexec and similar, so the sanity check would fail.
psmpi sets its own options for MPICH (its configure calls the MPICH configure), so the default MPICH options are not understood by the configure script of psmpi.

As it is now it won't work for us or any other psmpi user. We can, however, create a psmpi-specific easyblock. It might actually be the best solution. If we go down that way it would be helpful to separate the variable redefinition in a separate function, so we can override the configure_step without duplicating that piece of code. Thoughts (cc @ocaisa)?

hpcugentbot · 2016-03-01T19:34:45Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1728/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

…le fixes in MPICH/MVAPICH2 easyblocks

…nto mvapich2

boegel · 2016-03-01T19:54:08Z

@besserox: please take a look at besserox#3 that cleans this up a bit

rework use_new_libnames as named argument for sanity_check_step + style fixes in MPICH/MVAPICH2 easyblocks

hpcugentbot · 2016-03-01T21:37:07Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1730/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

more style fixes in MPICH easyblock

hpcugentbot · 2016-03-02T08:55:20Z

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1732/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2016-03-02T10:30:47Z

(re)tested thoroughly with existing MVAPICH2 easyconfigs + with the MPICH/MVAPICH2 easyconfigs from easybuilders/easybuild-easyconfigs#2589 (see test report at easybuilders/easybuild-easyconfigs#2589 (comment))

So, going in!

Thanks a lot for your efforts on this @damianam and @besserox!

Update easyblocks for MPICH and MVAPICH2

Damian Alvarez and others added 5 commits January 29, 2016 14:26

MPICH easyblock that reset some variables (xFLAGS) to make them match…

184d54f

… what the MPICH configure expects. MVAPICH2 now inherents from that easyblock instead of ConfigureMake

MPICH easyblock that reset some variables (xFLAGS) to make them match…

8b49867

… what the MPICH configure expects. MVAPICH2 now inherents from that easyblock instead of ConfigureMake

Merge branch 'develop' of https://github.com/hpcugent/easybuild-easyb…

fa0342c

…locks into mpich_derivatives_easyblocks Conflicts: easybuild/easyblocks/m/mvapich2.py

Couple of changes in the MPICH derivatives easyblocks

07586c9

Update sanity checks for MVAPICH2 easyblock for versions >= 2.1

a5bfa5f

MVAPICH2 library names have changed since version 2.1. These changes in the library names are inherited from MPICH 3.1.1 and above. cf http://git.mpich.org/mpich.git/blob_plain/v3.1.1:/CHANGES

besserox mentioned this pull request Feb 29, 2016

Update easyconfig files for MPICH and MVAPICH2 and their toolchains easybuilders/easybuild-easyconfigs#2589

Merged

boegel modified the milestones: v2.x, v2.7.0 Feb 29, 2016

Merge branch 'mpich_derivatives_easyblocks' of github.com:damianam/ea…

f14aba0

…sybuild-easyblocks into mvapich2 Fixed conflicts in easybuild/easyblocks/m/mvapich2.py

boegel mentioned this pull request Mar 1, 2016

style fixes in updated MVAPICH2 sanity check besserox/easybuild-easyblocks#2

Closed

boegel reviewed Mar 1, 2016
View reviewed changes

besserox added 3 commits March 1, 2016 14:33

Update sanity checks for MVAPICH2 and MPICH

7e5abf4

This also properly detects changes in libraries names depending on MPICH or MVAPICH2 version

Move MPICH specific options to MPICH easyblock

3a9e4b6

Force build of static libraries for MPICH and related

3572e47

This was already the default behavior, just force it as the sanity check except them.

Use a dedicated function to detect the use of the new library names i…

2dd07e3

…n MPICH and MVAPICH2 easyblocks

besserox changed the title ~~Update sanity checks for MVAPICH2 easyblock for versions >= 2.1~~ Update easyblocks for MPICH and MVAPICH2 Mar 1, 2016

Take some credit :-)

b1b961f

boegel added 2 commits March 1, 2016 20:40

rework use_new_libnames as named argument for sanity_check_step + sty…

ddc0284

…le fixes in MPICH/MVAPICH2 easyblocks

Merge branch 'mvapich2' of github.com:besserox/easybuild-easyblocks i…

e4bacb1

…nto mvapich2

boegel mentioned this pull request Mar 1, 2016

rework use_new_libnames as named argument for sanity_check_step + style fixes in MPICH/MVAPICH2 easyblocks besserox/easybuild-easyblocks#3

Merged

boegel and others added 5 commits March 1, 2016 21:27

pick up files/dirs being passed down

3ab7159

fix remark

f006cee

admit that @besserox was right

24b6ddc

fix remarks

676e90b

Merge pull request #3 from boegel/mvapich2

805f3a1

rework use_new_libnames as named argument for sanity_check_step + style fixes in MPICH/MVAPICH2 easyblocks

more style fixes in MPICH easyblock

b968fdc

boegel mentioned this pull request Mar 2, 2016

more style fixes in MPICH easyblock besserox/easybuild-easyblocks#4

Merged

Merge pull request #4 from boegel/mvapich2

a1e3003

more style fixes in MPICH easyblock

boegel added a commit that referenced this pull request Mar 2, 2016

Merge pull request #844 from besserox/mvapich2

7408519

Update easyblocks for MPICH and MVAPICH2

boegel merged commit 7408519 into easybuilders:develop Mar 2, 2016

boegel mentioned this pull request Mar 2, 2016

MPICH derivatives easyblocks #818

Merged

This was referenced Mar 2, 2016

Easyconfig files adapted to use the new MPICH easyblocks easybuilders/easybuild-easyconfigs#2399

Closed

Updated mpich derivatives easyconfigs easybuilders/easybuild-easyconfigs#2505

Closed

besserox deleted the mvapich2 branch March 3, 2016 13:14

besserox mentioned this pull request Mar 7, 2016

Remove deprecated configure options from MVAPICH2 easyblock #853

Merged

boegel mentioned this pull request Mar 11, 2016

xFLAGS in MPICH2, MVAPICH2 and potentially other MPICH2 derivatives easybuilders/easybuild-easyconfigs#2334

Closed

Conversation

besserox commented Feb 29, 2016

Uh oh!

hpcugentbot commented Feb 29, 2016

Uh oh!

boegel commented Feb 29, 2016

Uh oh!

boegel commented Feb 29, 2016

Uh oh!

hpcugentbot commented Feb 29, 2016

Uh oh!

besserox commented Feb 29, 2016

Uh oh!

damianam commented Mar 1, 2016

Uh oh!

boegel Mar 1, 2016

Choose a reason for hiding this comment

Uh oh!

boegel commented Mar 1, 2016

Uh oh!

boegel commented Mar 1, 2016

Uh oh!

hpcugentbot commented Mar 1, 2016

Uh oh!

hpcugentbot commented Mar 1, 2016

Uh oh!

besserox commented Mar 1, 2016

Uh oh!

boegel commented Mar 1, 2016

Uh oh!

damianam commented Mar 1, 2016

Uh oh!

hpcugentbot commented Mar 1, 2016

Uh oh!

boegel commented Mar 1, 2016

Uh oh!

hpcugentbot commented Mar 1, 2016

Uh oh!

hpcugentbot commented Mar 2, 2016

Uh oh!

boegel commented Mar 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants