Skip to content

use https in homepage/source_urls of zlib-1.2.11.eb#10018

Merged
smoors merged 1 commit intoeasybuilders:developfrom
boegel:20200307150608_new_pr_zlib1211
Mar 9, 2020
Merged

use https in homepage/source_urls of zlib-1.2.11.eb#10018
smoors merged 1 commit intoeasybuilders:developfrom
boegel:20200307150608_new_pr_zlib1211

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 7, 2020

This is a silly PR, but it'll serve as a test case for the fix for easybuilders/easybuild-framework#3233 (via boegelbot#1)...

edit: well, probably not, since getting the fix in easybuilders/easybuild-framework#3234 covered by the tests is not so straightforward... Still, it's a valid change/fix, so good to go...

@boegel boegel added the change label Mar 7, 2020
@boegel boegel added this to the next release (4.1.2?) milestone Mar 7, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 7, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/5fca880610abc4b27927b749f964cd7c for a full test report.

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Mar 9, 2020

Going in, thanks @boegel!

@smoors smoors merged commit 67c8891 into easybuilders:develop Mar 9, 2020
@boegel boegel deleted the 20200307150608_new_pr_zlib1211 branch March 9, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants