use correct target account/repo when creating test report & posting comment in PR#3234
Merged
zao merged 1 commit intoeasybuilders:developfrom Mar 7, 2020
Merged
Conversation
…omment in PR (fixes easybuilders#3233)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(fixes #3233)
This is quite difficult to cover in the tests, since i) we need to use
--dry-runto prevent that each run of the test suite adds a new comment to whichever PR we're using for the test, ii) we need to perform an actual installation in order to obtain a test report that can be uploaded, which implies we can not use--dry-runin the test...