Skip to content

minimap2 (foss-2018b and GCC-8.2.0*) include static lib and header#10464

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Darkless012:20200423162016_new_pr_minimap2213
Apr 24, 2020
Merged

minimap2 (foss-2018b and GCC-8.2.0*) include static lib and header#10464
boegel merged 2 commits intoeasybuilders:developfrom
Darkless012:20200423162016_new_pr_minimap2213

Conversation

@Darkless012
Copy link
Copy Markdown
Contributor

@Darkless012 Darkless012 commented Apr 23, 2020

(created using eb --new-pr)

boegel
boegel requested changes Apr 24, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/m/minimap2/minimap2-2.13-foss-2018b.eb Outdated
sanity_check_paths = {
'files': ['bin/%(name)s'],
'files': ['bin/%(name)s', 'lib/lib%(name)s.a'],
'dirs': []
Copy link
Copy Markdown
Member

@boegel boegel Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also check for non-empty include dir?

@boegel boegel added this to the next release (4.2.1?) milestone Apr 24, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3401.kirlia.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/c125f651e6a518848286c4f6d4a58213 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, x86_64, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/7bba3264adf0b03e05fe48ef25c6d1a1 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2020

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
node2401.golett.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/317132ca69db3c39e5b1793e51a59293 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2020

Going in, thanks @Darkless012!

@boegel boegel merged commit 1deef06 into easybuilders:develop Apr 24, 2020
@Darkless012 Darkless012 mentioned this pull request Apr 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@Darkless012 @boegel