Skip to content

{geo}[foss/2020a] CDAT v8.2.1, ... w/ Python 3.8.2#12322

Merged
boegel merged 9 commits intoeasybuilders:developfrom
zarybnicky:20210302173811_new_pr_cdat821
Mar 12, 2021
Merged

{geo}[foss/2020a] CDAT v8.2.1, ... w/ Python 3.8.2#12322
boegel merged 9 commits intoeasybuilders:developfrom
zarybnicky:20210302173811_new_pr_cdat821

Conversation

@zarybnicky
Copy link
Copy Markdown
Contributor

@zarybnicky zarybnicky commented Mar 2, 2021 •
edited by boegel
Loading

(created using eb --new-pr)

requires #12349 + easybuilders/easybuild-easyblocks#2357 (enabling -fPIC for g2clib, and making sure it's actually used)

adding easyconfigs: cdat-8.2.1-foss-2020a-Python-3.8.2.eb, cdat_info-…
cd5998b 
…8.2.1-GCCcore-9.3.0-Python-3.8.2.eb, gdbm-1.18.1-foss-2020a.eb, libcdms-3.1.2-foss-2020a.eb, libdrs-3.1.2-foss-2020a.eb, unidata-2.8-foss-2020a-Python-3.8.2.eb and patches: cdms2-3.1.5-intel-2020a.patch, dv3d-pkg_resource-paths.patch, pycf-1.6.9-openblas.patch, unidata-2.8-package-data.patch
@zarybnicky zarybnicky changed the title {lib}[foss/2020a] cdat v8.2.1, cdat_info v8.2.1, gdbm v1.18.1, ... w/ Python 3.8.2 {lib}[foss/2020a] cdat v8.2.1, ... w/ Python 3.8.2 Mar 2, 2021
verdurin
verdurin previously requested changes Mar 2, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/c/cdat/cdat-8.2.1-foss-2020a-Python-3.8.2.eb Outdated
Comment thread easybuild/easyconfigs/c/cdat/cdms2-3.1.5-intel-2020a.patch
Comment thread easybuild/easyconfigs/c/cdat/dv3d-pkg_resource-paths.patch
Comment thread easybuild/easyconfigs/c/cdat/pycf-1.6.9-openblas.patch Outdated
Comment thread easybuild/easyconfigs/c/cdat_info/cdat_info-8.2.1-GCCcore-9.3.0-Python-3.8.2.eb Outdated
Comment thread easybuild/easyconfigs/g/gdbm/gdbm-1.18.1-foss-2020a.eb Outdated
Comment thread easybuild/easyconfigs/l/libcdms/libcdms-3.1.2-foss-2020a.eb
Comment thread easybuild/easyconfigs/u/unidata/unidata-2.8-foss-2020a-Python-3.8.2.eb Outdated
Comment thread easybuild/easyconfigs/u/unidata/unidata-2.8-package-data.patch
boegel
boegel requested changes Mar 2, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/c/cdat/cdat-8.2.1-foss-2020a-Python-3.8.2.eb Outdated
Comment thread easybuild/easyconfigs/c/cdat/cdat-8.2.1-foss-2020a-Python-3.8.2.eb Outdated
Comment thread easybuild/easyconfigs/c/cdat/cdat-8.2.1-foss-2020a-Python-3.8.2.eb Outdated
Comment thread easybuild/easyconfigs/c/cdat/cdat-8.2.1-foss-2020a-Python-3.8.2.eb Outdated
Comment thread easybuild/easyconfigs/c/cdat/cdms2-3.1.5-intel-2020a.patch
Comment thread easybuild/easyconfigs/c/cdat_info/cdat_info-8.2.1-GCCcore-9.3.0-Python-3.8.2.eb Outdated
Comment thread easybuild/easyconfigs/g/gdbm/gdbm-1.18.1-foss-2020a.eb Outdated
Comment thread easybuild/easyconfigs/l/libcdms/libcdms-3.1.2-foss-2020a.eb
Comment thread easybuild/easyconfigs/l/libcdms/libcdms-3.1.2-foss-2020a.eb Outdated
Comment thread easybuild/easyconfigs/u/unidata/unidata-2.8-package-data.patch
@zarybnicky
Copy link
Copy Markdown
Contributor Author

zarybnicky commented Mar 3, 2021

I hurried it a bit yesterday, wanted to do the PR and didn't clean up after myself, this should be better :)

@zarybnicky zarybnicky changed the title {lib}[foss/2020a] cdat v8.2.1, ... w/ Python 3.8.2 {geo}[foss/2020a] CDAT v8.2.1, ... w/ Python 3.8.2 Mar 3, 2021
@easybuilders easybuilders deleted a comment from boegelbot Mar 5, 2021
boegel
boegel requested changes Mar 5, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/l/libcdms/libcdms-3.1.2-foss-2020a-Python-3.8.2.eb Outdated
Comment thread easybuild/easyconfigs/g/gdbm/gdbm-1.18.1-foss-2020a.eb Outdated
Comment thread easybuild/easyconfigs/l/libdrs/libdrs-3.1.2-foss-2020a.eb Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 5, 2021

@zarybnicky It looks we need to enable -fPIC in a dependency too, see upcoming test report?

Please open a separate PR for that, since it's a change in an existing easyconfig

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 5, 2021

Test report by @boegel
FAILED
Build succeeded for 3 out of 4 (4 easyconfigs in total)
node3162.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/24f6abfd4775ae5ebab700436860ac67 for a full test report.

@zarybnicky
Copy link
Copy Markdown
Contributor Author

zarybnicky commented Mar 8, 2021 •
edited by boegel
Loading

Waiting for #12349

@zarybnicky zarybnicky mentioned this pull request Mar 8, 2021
Merged
boegel
boegel requested changes Mar 8, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/c/CDAT/CDAT-8.2.1-foss-2020a-Python-3.8.2.eb Outdated
@boegel boegel added the new label Mar 11, 2021
@boegel boegel added this to the next release (4.3.4?) milestone Mar 11, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 11, 2021

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3507.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/f47e5651d724c626424007029c9b5ced for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 11, 2021

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3170.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/a715ee401b0346c63c92cc880bd10e20 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 11, 2021

@boegelbot please test @ generoso

@easybuilders easybuilders deleted a comment from boegelbot Mar 11, 2021
@easybuilders easybuilders deleted a comment from boegelbot Mar 11, 2021
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 11, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12322 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12322 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16345

Test results coming soon (I hope)...

Details

- notification for comment with ID 797018777 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 11, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/2454995b10d030c8aebe9502d77c7132 for a full test report.

boegel
boegel approved these changes Mar 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel dismissed verdurin’s stale review March 12, 2021 07:44

requested changes made

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 12, 2021

Going in, thanks @zarybnicky!

@boegel boegel merged commit 7e3a3a9 into easybuilders:develop Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@verdurin verdurin verdurin left review comments

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@zarybnicky @boegel @boegelbot @verdurin