Skip to content

enable -fPIC for g2clib#12349

Merged
boegel merged 5 commits intoeasybuilders:developfrom
zarybnicky:20210308093007_new_pr_g2clib160
Mar 8, 2021
Merged

enable -fPIC for g2clib#12349
boegel merged 5 commits intoeasybuilders:developfrom
zarybnicky:20210308093007_new_pr_g2clib160

Conversation

@zarybnicky
Copy link
Copy Markdown
Contributor

@zarybnicky zarybnicky commented Mar 8, 2021 •
edited by boegel
Loading

(created using eb --new-pr)

Required for CDAT (#12322)

edit (by @boegel): also requires easybuilders/easybuild-easyblocks#2357 to actually have an effect...

@zarybnicky zarybnicky mentioned this pull request Mar 8, 2021
Merged
@boegel boegel changed the title g2clib: compile with -fPIC enable -fPIC for g2clib Mar 8, 2021
@boegel boegel added the change label Mar 8, 2021
@boegel boegel added this to the next release (4.3.4?) milestone Mar 8, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 8, 2021

@boegelbot please test @ generoso
EB_ARGS="g2clib-1.6.0-GCCcore-8.3.0.eb g2clib-1.6.0-GCCcore-9.3.0.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 8, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12349 EB_ARGS="g2clib-1.6.0-GCCcore-8.3.0.eb g2clib-1.6.0-GCCcore-9.3.0.eb" /apps/slurm/default/bin/sbatch --job-name test_PR_12349 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16333

Test results coming soon (I hope)...

Details

- notification for comment with ID 792795728 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 8, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-c1-s-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/7418215ff021d351b128ad421c553f9d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 8, 2021

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node2717.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/6f7e7ee20f7d91428e974ff008716048 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 8, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2717.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/0f8265e64e59cfe3732c7b2892e0c298 for a full test report.

@boegel boegel enabled auto-merge March 8, 2021 14:49
@boegel boegel added the bug fix label Mar 8, 2021
boegel
boegel approved these changes Mar 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 7099c16 into easybuilders:develop Mar 8, 2021
@boegel boegel mentioned this pull request Mar 11, 2021
Merged
@easybuilders easybuilders deleted a comment from boegelbot Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@zarybnicky @boegel @boegelbot