improve check for multi-variant dependencies per generation of easyconfigs (for now, only for 2025a & newer)#12687
Merged
jfgrimm merged 17 commits intoeasybuilders:developfrom Jun 18, 2025
Conversation
…olchain, since it depends on Java 1.8
Member
Author
|
Once the tests pass, I should probably pull out the edit: see #12709 |
Member
Author
|
I need to verify that this indeed picks up on different dependency variants across (sub)toolchains in the same generation, so don't merge this just yet... |
Contributor
|
Just remembered this old PR as we recently had the case that there is a Java 17 and Java 21 in our toolchain as some easyconfigs were GCC(core) and others foss so the conflict was missed. |
Contributor
|
Yeah, ping @boegel |
branfosj
reviewed
Jun 16, 2025
branfosj
reviewed
Jun 16, 2025
| from easybuild.framework.easyconfig.tools import check_sha256_checksums, dep_graph, get_paths_for, process_easyconfig | ||
| from easybuild.tools import config, LooseVersion | ||
| from easybuild.tools.build_log import EasyBuildError | ||
| from easybuild.tools.build_log import EasyBuildError, print_warning |
Member
There was a problem hiding this comment.
Suggested change
| from easybuild.tools.build_log import EasyBuildError, print_warning | |
| from easybuild.tools.build_log import EasyBuildError |
branfosj
reviewed
Jun 16, 2025
…tion to only cover 2025a generation & newer, for now
Member
Author
|
@branfosj Let's throw that info in dedicated issues (per toolchain generation), so we can follow up? |
This was referenced Jun 18, 2025
e041877 to
0a1c5e8
Compare
Member
0a1c5e8 to
3cfa544
Compare
jfgrimm
approved these changes
Jun 18, 2025
Member
|
Going in, thanks @boegel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues fixed:
GCCtoolchain;GCCcore-10.*toolchain;