restore toolchain multideps test#23177
Merged
Micket merged 6 commits intoeasybuilders:developfrom Jun 23, 2025
Merged
Conversation
branfosj
commented
Jun 21, 2025
Micket
reviewed
Jun 21, 2025
| # compiler-only subtoolchains GCCcore and GCC | ||
| # r'GCCcore-[7-9]\.[0-9]\.', | ||
| # r'GCC(core)?-1[0-9]\.[0-9]\.', # GCCcore 10.x, etc. | ||
| r'GCC(core)?-1[3-9]\.[0-9]\.', # GCCcore 13.x & newer |
Contributor
There was a problem hiding this comment.
Do we also want to check for intel-compilers?
Member
Author
There was a problem hiding this comment.
Possibly, but I'd like to do that as a follow on and use this PR for restoring the previous check.
Micket
approved these changes
Jun 23, 2025
Contributor
Micket
left a comment
There was a problem hiding this comment.
lgtm, but I think we should really just have
def test_versions_per_toolchain(self):
that verifies that we only have one version of something per toolchain (with some exceptions), as the existence of these alterantive versions we occasionally have is just a net negative. Like two versions of giflib that tripped me up yesterday and what not.
In particular for GCCcore level, just one version of things please (unless strongly motivated why not).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12687 switched to testing for multidep variants per toolchain generation, but this is only enabled for 2023b and newer.
We should still test for multidep variants per toolchain for the older generations.
The previous check (
r'GCCcore-([7-9]|[1-9][0-9])\.[0-9]') missedGCCtoolchains and I've retained that due to there being multidep variant failures inGCCtoolchains. The check on the newer generations will catch these problems, so the historical ones will get archived away over time.