Skip to content

{bio}[GCC/9.3.0] vcflib v1.0.2 + deps#12841

Merged
branfosj merged 7 commits intoeasybuilders:developfrom
jfgrimm:20210510153016_new_pr_vcflib102
May 21, 2021
Merged

{bio}[GCC/9.3.0] vcflib v1.0.2 + deps#12841
branfosj merged 7 commits intoeasybuilders:developfrom
jfgrimm:20210510153016_new_pr_vcflib102

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented May 10, 2021 •
edited
Loading

(created using eb --new-pr)
typo in original commit msg - require(d) #12837 #12838 #12839

@boegelbot

This comment has been minimized.

Sign in to view
@lexming
Copy link
Copy Markdown
Contributor

lexming commented May 11, 2021

Test report by @lexming
FAILED
Build succeeded for 7 out of 8 (5 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/8155190c979a19619e90f5ed374b1038 for a full test report.

This was referenced May 13, 2021
Merged
Merged
@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented May 18, 2021

Test report by @jfgrimm
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node031.pri.viking.alces.network - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz, Python 2.7.5
See https://gist.github.com/4ed134adf714aa5f4ea973de0df4f31e for a full test report.

@branfosj branfosj added this to the 4.x milestone May 21, 2021
@branfosj branfosj added the new label May 21, 2021
branfosj
branfosj requested changes May 21, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are suitable items for sanity_check_commands then it would be good to add some checks on the executables.

Comment thread easybuild/easyconfigs/f/fsom/fsom-20141119_fix-abs-overload.patch
Comment thread easybuild/easyconfigs/s/smithwaterman/smithwaterman-20160702_build-shared-lib.patch
Comment thread easybuild/easyconfigs/v/vcflib/vcflib-1.0.2_use-external-deps.patch
Comment thread easybuild/easyconfigs/v/vcflib/vcflib-1.0.2-GCC-9.3.0-Python-3.8.2.eb
@jfgrimm jfgrimm requested a review from branfosj May 21, 2021 15:04
@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented May 21, 2021

@branfosj thanks for taking a look! I've added author/desc to the patches that were missing it, and have added some sanity_check_commands.

@easybuilders easybuilders deleted a comment from boegelbot May 21, 2021
@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 21, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 21, 2021

@branfosj: Request for testing this PR well received on generoso

PR test command 'EB_PR=12841 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12841 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17276

Test results coming soon (I hope)...

Details

- notification for comment with ID 846124415 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 21, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/d0f934269cef83686350ba1c5a0fa217 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 21, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/f2ba4047ed8e49b4929721afeb9be793 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 21, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (5 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/5635cd5b8fe8e7acaf8fc62b98e23bad for a full test report.

@branfosj branfosj modified the milestones: 4.x, 4.4.0 May 21, 2021
@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 21, 2021

Going in, thanks @jfgrimm!

@branfosj branfosj merged commit 96487b0 into easybuilders:develop May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jfgrimm @boegelbot @lexming @branfosj