add missing dependencies for recent LibTIFF versions: XZ, jbigkit, zstd by smoors · Pull Request #14079 · easybuilders/easybuild-easyconfigs

smoors · 2021-09-30T13:17:22Z

(created using eb --new-pr)

smoors · 2021-09-30T13:36:45Z

@boegelbot: please test @ generoso

akesandgren · 2021-09-30T13:39:43Z

@smoors note that at least LibTIFF 4.2.0 tries to find jbigkit too
This is the config_step summary for 4.2.0:

 Support for external codecs:
  ZLIB support:                       yes
  libdeflate support:                 no
  Pixar log-format algorithm:         yes
  JPEG support:                       yes
  Old JPEG support:                   yes
  JPEG 8/12 bit dual mode:            no
  ISO JBIG support:                   no
  LZMA2 support:                      no
  ZSTD support:                       no
  WEBP support:                       no

  C++ support:                        yes

  OpenGL support:                     no

boegelbot · 2021-09-30T13:40:11Z

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=14079 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14079 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 7012

Test results coming soon (I hope)...

Details

- notification for comment with ID 931330126 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2021-09-30T13:43:48Z

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/fcca00d5d213bacc9a3d2c3c5d7b500b for a full test report.

smoors · 2021-09-30T14:35:49Z

@akesandgren good point. should we add ZSTD too then?

smoors · 2021-09-30T14:46:15Z

in any case it would be good to explicitly disable the formats for deps that are not included, so they don't get picked up from the system.

akesandgren · 2021-09-30T14:48:40Z

Yeah we should add it and explicitly disable stuff we're not adding deps for, if possible.

SebastianAchilles · 2021-09-30T20:27:47Z

Depends on jbigkit-2.1-GCCcore-11.2.0.eb {vis}[GCCcore/11.2.0] jbigkit v2.1 + add missing header file to older versions #14081

…asyconfigs into 20210930151718_new_pr_LibTIFF410

smoors · 2021-10-03T18:43:25Z

@boegelbot: please test @ generoso

boegelbot · 2021-10-03T18:45:08Z

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=14079 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14079 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 7032

Test results coming soon (I hope)...

Details

- notification for comment with ID 933004374 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2021-10-03T18:49:04Z

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/ecadcb5ec1152ad5ad36adebd0680ef9 for a full test report.

smoors · 2021-10-03T18:55:36Z

with this PR and the fixes in PR #14081, the config looks now like this:

 Support for external codecs:
  ZLIB support:                       yes
  libdeflate support:                 no
  Pixar log-format algorithm:         yes
  JPEG support:                       yes
  Old JPEG support:                   yes
  JPEG 8/12 bit dual mode:            no
  ISO JBIG support:                   yes
  LZMA2 support:                      yes
  ZSTD support:                       yes
  WEBP support:                       no

  C++ support:                        yes

  OpenGL support:                     no

lexming · 2021-10-16T20:24:23Z

Test report by @lexming
SUCCESS
Build succeeded for 29 out of 29 (5 easyconfigs in total)
node305.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/c65f6d561f0dfe94b71eccaf432d3ae4 for a full test report.

lexming

LGTM

lexming · 2021-10-16T23:05:35Z

Going in, thanks @smoors !

add missing XZ dependency for recent LibTIFF versions

106c9de

smoors added the bug fix label Sep 30, 2021

smoors added this to the 4.x milestone Sep 30, 2021

also add jbigkit and zstd

5c26389

smoors mentioned this pull request Oct 1, 2021

{vis}[GCCcore/11.2.0] jbigkit v2.1 + add missing header file to older versions #14081

Merged

Merge branch 'develop' of https://github.com/easybuilders/easybuild-e…

d0f9358

…asyconfigs into 20210930151718_new_pr_LibTIFF410

easybuilders deleted a comment from boegelbot Oct 3, 2021

smoors modified the milestones: 4.x, next release (4.5.0?) Oct 3, 2021

smoors mentioned this pull request Oct 3, 2021

{bio}[GCCcore/10.2.0] MotionCor2 v1.4.4 #14074

Merged

lexming approved these changes Oct 16, 2021

View reviewed changes

lexming merged commit 6cf9412 into easybuilders:develop Oct 16, 2021

boegel changed the title ~~add missing XZ dependency for recent LibTIFF versions~~ add missing dependencies for recent LibTIFF versions: XZ, jbigkit, zstd Oct 27, 2021

boegel mentioned this pull request Oct 27, 2021

"multiple definition of" linking error when building scikit-image with intel toolchain #14219

Closed

boegel added the change label Oct 27, 2021

Flamefire mentioned this pull request Feb 21, 2024

stop using non-existent --disable-libdeflate option for LibTIFF 4.1.0 #19951

Merged

Conversation

smoors commented Sep 30, 2021

Uh oh!

smoors commented Sep 30, 2021

Uh oh!

akesandgren commented Sep 30, 2021

Uh oh!

boegelbot commented Sep 30, 2021

Uh oh!

boegelbot commented Sep 30, 2021

Uh oh!

smoors commented Sep 30, 2021

Uh oh!

smoors commented Sep 30, 2021

Uh oh!

akesandgren commented Sep 30, 2021

Uh oh!

SebastianAchilles commented Sep 30, 2021 • edited by smoors Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smoors commented Oct 3, 2021

Uh oh!

boegelbot commented Oct 3, 2021

Uh oh!

boegelbot commented Oct 3, 2021

Uh oh!

smoors commented Oct 3, 2021

Uh oh!

lexming commented Oct 16, 2021

Uh oh!

lexming left a comment

Choose a reason for hiding this comment

Uh oh!

lexming commented Oct 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SebastianAchilles commented Sep 30, 2021 •

edited by smoors

Loading