Skip to content

stop using non-existent --disable-libdeflate option for LibTIFF 4.1.0#19951

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
Flamefire:20240221154805_new_pr_LibTIFF410
Feb 22, 2024
Merged

stop using non-existent --disable-libdeflate option for LibTIFF 4.1.0#19951
jfgrimm merged 1 commit intoeasybuilders:developfrom
Flamefire:20240221154805_new_pr_LibTIFF410

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Feb 21, 2024 •
edited
Loading

(created using eb --new-pr)

That option was added in 4.2.0 see https://gitlab.com/libtiff/libtiff/-/commit/3a2de853a932bd0ea79d1677d319841edb736c38

But it was wrongly added to the ECs in #14079

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Feb 21, 2024

Test report by @Flamefire
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
n1170 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/81cf14f76aaebb1f22d8b407d6f1ac20 for a full test report.

@jfgrimm jfgrimm added this to the release after 4.9.0 milestone Feb 22, 2024
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 22, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 22, 2024

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=19951 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19951 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12946

Test results coming soon (I hope)...

Details

- notification for comment with ID 1959671800 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 22, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node032.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/bda5601a9e899344ef495f49e4c8ca90 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 22, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/5af086548c0fc92ae3a1f02701208eb4 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 22, 2024

@boegelbot: please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 22, 2024

@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19951 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19951 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3656

Test results coming soon (I hope)...

Details

- notification for comment with ID 1959726275 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 22, 2024

Test report by @boegelbot
FAILED
Build succeeded for 8 out of 33 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/8c7db0ce3f413238de5ec02f20aaa421 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 22, 2024

failures on jsc-zen3 look to be due to bootstrapping old compilers on a newer OS

jfgrimm
jfgrimm approved these changes Feb 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 22, 2024

Going in, thanks @Flamefire!

@jfgrimm jfgrimm merged commit 0e222fb into easybuilders:develop Feb 22, 2024
@Flamefire Flamefire deleted the 20240221154805_new_pr_LibTIFF410 branch February 23, 2024 15:03
@boegel boegel changed the title Remove --disable-libdeflate option from LibTIFF 4.1.0 stop using non-existent --disable-libdeflate option for LibTIFF 4.1.0 Feb 28, 2024
@boegel boegel mentioned this pull request Mar 11, 2024
Merged
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @jfgrimm @boegelbot