Skip to content

consistently apply patch for mapDamage 2.2.1 to use external seqtk#14961

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
boegel:20220208115127_new_pr_mapDamage221
Feb 8, 2022
Merged

consistently apply patch for mapDamage 2.2.1 to use external seqtk#14961
jfgrimm merged 1 commit intoeasybuilders:developfrom
boegel:20220208115127_new_pr_mapDamage221

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 8, 2022

(created using eb --new-pr)

@boegel boegel added the bug fix label Feb 8, 2022
@boegel boegel added this to the next release (4.5.3?) milestone Feb 8, 2022
@boegel boegel requested a review from jfgrimm February 8, 2022 10:54
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 8, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3523.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/8613f246fd7b83edf5b80999995b772f for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 8, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 8, 2022

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14961 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14961 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8099

Test results coming soon (I hope)...

Details

- notification for comment with ID 1032476827 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 8, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 8, 2022

@boegel: Request for testing this PR well received on jsfl1.int.jusuf.sebastian.cluster

PR test command 'EB_PR=14961 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14961 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1790

Test results coming soon (I hope)...

Details

- notification for comment with ID 1032481472 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 8, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/ca72227f637996b3295990c3496c1506 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 8, 2022

Test report by @jfgrimm
FAILED
Build succeeded for 1 out of 3 (2 easyconfigs in total)
node084.pri.viking.alces.network - Linux UNKNOWN UNKNOWN, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/06032dd12e3a5de8726b1faba0868149 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 8, 2022 •
edited
Loading

@boegel RcppGSL-0.3.8-foss-2020b-R-4.0.4.eb#L16 has a typo in the templating
(it uses $(name)s instead of %(name)s)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 8, 2022

@boegel RcppGSL-0.3.8-foss-2020b-R-4.0.4.eb#L16 has a typo in the templating (it uses $(name)s instead of %(name)s)

Ugh, ok, let's fix that in another PR?

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 8, 2022

yeah I'll open one in a sec

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 8, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node084.pri.viking.alces.network - Linux UNKNOWN UNKNOWN, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/742f9aaeea3f23cb2832b4e8309fad27 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 8, 2022

@boegel I've opened #14962 to address the source url issue

jfgrimm
jfgrimm approved these changes Feb 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 8, 2022

Going in, thanks @boegel!

@jfgrimm jfgrimm merged commit 77981fd into easybuilders:develop Feb 8, 2022
@boegel boegel deleted the 20220208115127_new_pr_mapDamage221 branch February 8, 2022 12:01
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 8, 2022

Test report by @boegelbot
FAILED
Build succeeded for 55 out of 57 (2 easyconfigs in total)
jsfc01.int.jusuf.sebastian.cluster - Linux Rocky Linux 8.4, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/0c862c90c58d33745f2c0d3d1cf5a3e8 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.3

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @jfgrimm