Skip to content

fix typo in templated source URL in RcppGSL 0.3.8 easyconfig: $(name)s should be %(name)s#14962

Merged
boegel merged 1 commit intoeasybuilders:developfrom
jfgrimm:20220208111430_new_pr_RcppGSL038
Feb 8, 2022
Merged

fix typo in templated source URL in RcppGSL 0.3.8 easyconfig: $(name)s should be %(name)s#14962
boegel merged 1 commit intoeasybuilders:developfrom
jfgrimm:20220208111430_new_pr_RcppGSL038

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Feb 8, 2022

(created using eb --new-pr)

@jfgrimm jfgrimm mentioned this pull request Feb 8, 2022
Merged
@jfgrimm jfgrimm requested a review from boegel February 8, 2022 11:18
@jfgrimm jfgrimm added the bug fix label Feb 8, 2022
@jfgrimm jfgrimm added this to the next release (4.5.3?) milestone Feb 8, 2022
boegel
boegel approved these changes Feb 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 8, 2022

@boegelbot please test @ generoso
EB_ARGS="--force-download"

@boegel boegel changed the title Fix typo in RcppGSL 0.3.8 source url fix typo in templated source URL in RcppGSL 0.3.8 easyconfig: $(name)s should be %(name)s Feb 8, 2022
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 8, 2022

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14962 EB_ARGS="--force-download" /opt/software/slurm/bin/sbatch --job-name test_PR_14962 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8100

Test results coming soon (I hope)...

Details

- notification for comment with ID 1032922167 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 8, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/411ed4760171828819bca3e55953a603 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 8, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3523.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/8e0c8acd2da12a32acb714ef9732393b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 8, 2022

Going in, thanks @jfgrimm!

@boegel boegel merged commit c8ffd68 into easybuilders:develop Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.3

Development

Successfully merging this pull request may close these issues.

3 participants

@jfgrimm @boegel @boegelbot