Skip to content

add patch for pybind11 2.6.0 to fix failing test due to extra whitespace#16487

Merged
smoors merged 2 commits intoeasybuilders:developfrom
sassy-crick:20221025185039_new_pr_pybind11260
Oct 27, 2022
Merged

add patch for pybind11 2.6.0 to fix failing test due to extra whitespace#16487
smoors merged 2 commits intoeasybuilders:developfrom
sassy-crick:20221025185039_new_pr_pybind11260

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Oct 25, 2022 •
edited by boegel
Loading

(created using eb --new-pr)

cfr. pybind/pybind11#3680

@boegel boegel changed the title Patch added to ensure test-jobs are not failing due to blanks (https://github.com/pybind/pybind11/issues/3680) add patch for pybind11 2.6.0 to fix failing test due to extra whitespace Oct 26, 2022
@boegel boegel added the bug fix label Oct 26, 2022
@boegel boegel added this to the next release (4.6.3?) milestone Oct 26, 2022
boegel
boegel previously requested changes Oct 26, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/p/pybind11/pybind11-2.6.0-GCCcore-10.2.0.eb Outdated
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 26, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 26, 2022

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=16487 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16487 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9389

Test results coming soon (I hope)...

Details

- notification for comment with ID 1292586054 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 26, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/bf0f92a06486d9399750d44449c4bbde for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 27, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 27, 2022

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16487 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16487 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1732

Test results coming soon (I hope)...

Details

- notification for comment with ID 1293197755 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 27, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/9cf8f5108bdf33aa90cafc98c4dceb0d for a full test report.

smoors
smoors previously approved these changes Oct 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors dismissed their stale review October 27, 2022 09:18

changes done

@smoors smoors dismissed boegel’s stale review October 27, 2022 09:20

changed done

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 27, 2022

Going in, thanks @sassy-crick!

@smoors smoors merged commit a673096 into easybuilders:develop Oct 27, 2022
@sassy-crick sassy-crick deleted the 20221025185039_new_pr_pybind11260 branch November 1, 2022 15:59
@branfosj branfosj mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

@boegel boegel boegel left review comments

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sassy-crick @smoors @boegelbot @boegel