Skip to content

use existing patch in pybind11 2.6.2 and 2.7.1 to fix failing test due to extra whitespace#19279

Merged
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20231121205659_new_pr_pybind11262
Nov 22, 2023
Merged

use existing patch in pybind11 2.6.2 and 2.7.1 to fix failing test due to extra whitespace#19279
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20231121205659_new_pr_pybind11262

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Nov 21, 2023 •
edited
Loading

(created using eb --new-pr)

Use the patch from #16487 in these pybind11 as well. This was fixed upstream in 2.9.2.

@branfosj branfosj added this to the next release (4.9.0?) milestone Nov 21, 2023
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Nov 21, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2023

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=19279 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19279 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12209

Test results coming soon (I hope)...

Details

- notification for comment with ID 1821714202 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Nov 21, 2023

@boegelbot please test @ jsc-zen2

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Nov 21, 2023

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (3 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/3ef73bf7d781c0efd1132494dbf69843 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2023

@branfosj: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19279 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19279 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3774

Test results coming soon (I hope)...

Details

- notification for comment with ID 1821720753 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/a4eda356921f80ab74b550fed05af6c3 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/5032826df60c7b2b7483dd332ad50921 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 21, 2023

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3144.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/67c6f10955350347f0ddc64053c47580 for a full test report.

boegel
boegel approved these changes Nov 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 22, 2023

Going in, thanks @branfosj!

@boegel boegel merged commit 646550b into easybuilders:develop Nov 22, 2023
@branfosj branfosj deleted the 20231121205659_new_pr_pybind11262 branch November 22, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegelbot @boegel