Skip to content

fix homepage + source URL for ELPA (due to switch to new domain)#17357

Merged
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20230216104608_new_pr_ELPA201711001
Feb 26, 2023
Merged

fix homepage + source URL for ELPA (due to switch to new domain)#17357
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20230216104608_new_pr_ELPA201711001

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 16, 2023 •
edited
Loading

(created using eb --new-pr)

partial fix for #17162 (other ELPA easyconfigs also need changed homepage)

no change in checksums

@boegel boegel added the bug fix label Feb 16, 2023
@boegel boegel added this to the next release (4.7.1?) milestone Feb 16, 2023
@boegel boegel mentioned this pull request Feb 16, 2023
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 16, 2023

@boegelbot please test @ generoso
EB_ARGS="--sourcepath /tmp/$USER/pr17357 --force-download --stop source"

@boegel boegel mentioned this pull request Feb 16, 2023
Closed
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 16, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17357 EB_ARGS="--sourcepath /tmp/$USER/pr17357 --force-download --stop source" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17357 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10254

Test results coming soon (I hope)...

Details

- notification for comment with ID 1432815738 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 16, 2023

Test report by @boegelbot
FAILED
Build succeeded for 31 out of 35 (15 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/a17d13cbb3161cc5ec4c981bcfb75eca for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Feb 16, 2023

@boegel from a quick look it appears the failures relate to the older Intel toolchains, and can probably be ignored?

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 18, 2023

@boegelbot please test @ generoso
EB_ARGS="ELPA-2020.11.001-foss-2020b.eb ELPA-2020.11.001-intel-2020b.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 18, 2023

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=17357 EB_ARGS="ELPA-2020.11.001-foss-2020b.eb ELPA-2020.11.001-intel-2020b.eb" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17357 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10272

Test results coming soon (I hope)...

Details

- notification for comment with ID 1435529084 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 18, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/309ee4857ba3758b5d6066ffb665aa6b for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 18, 2023

Those rebuilds were for missing modules while testing #17359

Micket
Micket approved these changes Feb 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 26, 2023

Going in, thanks @boegel!

@Micket Micket merged commit 8eda6d9 into easybuilders:develop Feb 26, 2023
@boegel boegel deleted the 20230216104608_new_pr_ELPA201711001 branch February 26, 2023 18:53
@SebastianAchilles SebastianAchilles mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

5 participants

@boegel @boegelbot @verdurin @branfosj @Micket