Skip to content

rename libpsml for consistency with libPSML#17359

Merged
lexming merged 2 commits intoeasybuilders:developfrom
branfosj:libPSML
Feb 20, 2023
Merged

rename libpsml for consistency with libPSML#17359
lexming merged 2 commits intoeasybuilders:developfrom
branfosj:libPSML

Conversation

@branfosj
Copy link
Copy Markdown
Member

for #11824

@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/d3ea4614496bae5919c5ce0df4d94bfa for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

The test report covers all apart from the 2016b and 2017a easyconfigs.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 17, 2023

Right so this is probably the most controversial change. Though it isn't used as a dependency in other stuff much, someone still felt the need to update it to pretty recent GCCcore's, so i assume it's used by users in some way still?

Probably still alright to rename it i.m.h.o. to just get this issue over with

@branfosj
Copy link
Copy Markdown
Member Author

If we do the change the other way round (#17353) we alter fewer easyconfigs, but the libPSML capitalisation is also a dependency. These are recent enough easyconfigs that we cannot use the archive approach.

So, yes this is not a great option. However, I see no better one to avoid this libpsml / libPSML problem remaining.

@jfgrimm jfgrimm added the change label Feb 17, 2023
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 17, 2023

@boegelbot please test @ generoso

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 17, 2023

I think the oldest ones here is to old for generoso as well

@boegelbot
Copy link
Copy Markdown
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=17359 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17359 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10266

Test results coming soon (I hope)...

Details

- notification for comment with ID 1434786667 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 17, 2023

I think the oldest ones here is to old for generoso as well

whoops, looks like the oldest toolchain it has is 2018b...

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 19 out of 65 (10 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/89f0eb6085210317f2e7e21cbafeeb0c for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 17, 2023

@boegelbot please test @ generoso
EB_ARGS="libPSML-1.1.10-GCC-10.3.0.eb libPSML-1.1.10-GCC-10.2.0.eb libPSML-1.1.10-GCC-11.2.0.eb libPSML-1.1.10-iccifort-2020.4.304.eb libPSML-1.1.10-intel-compilers-2021.2.0.eb libPSML-1.1.10-intel-compilers-2021.4.0.eb ESL-Bundle-0.6.1-intel-2020b.eb ESL-Bundle-0.6.1-foss-2020b.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=17359 EB_ARGS="libPSML-1.1.10-GCC-10.3.0.eb libPSML-1.1.10-GCC-10.2.0.eb libPSML-1.1.10-GCC-11.2.0.eb libPSML-1.1.10-iccifort-2020.4.304.eb libPSML-1.1.10-intel-compilers-2021.2.0.eb libPSML-1.1.10-intel-compilers-2021.4.0.eb ESL-Bundle-0.6.1-intel-2020b.eb ESL-Bundle-0.6.1-foss-2020b.eb" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17359 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10270

Test results coming soon (I hope)...

Details

- notification for comment with ID 1435051557 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 6 out of 8 (8 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/615dc338c5b0f7648c309aaf34c1076c for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

@boegelbot please test @ generoso
EB_ARGS="--filter-ecs=2016b,2017a"

@boegelbot
Copy link
Copy Markdown
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=17359 EB_ARGS="--filter-ecs=*2016b*,*2017a*" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17359 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10273

Test results coming soon (I hope)...

Details

- notification for comment with ID 1435639032 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f8187dce0983301a1d6db005ef69bbf9 for a full test report.

Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Feb 20, 2023

Going in, thanks @branfosj !

@lexming lexming merged commit b07d893 into easybuilders:develop Feb 20, 2023
@branfosj branfosj deleted the libPSML branch February 21, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants