Skip to content

Add easyconfig for PGI 15.7 using GCC 4.9.2 libraries.#1833

Merged
boegel merged 4 commits intoeasybuilders:developfrom
bartoldeman:pgi
Jan 23, 2016
Merged

Add easyconfig for PGI 15.7 using GCC 4.9.2 libraries.#1833
boegel merged 4 commits intoeasybuilders:developfrom
bartoldeman:pgi

Conversation

@bartoldeman
Copy link
Copy Markdown
Contributor

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PGI?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartoldeman: we try to stick to the 'official' software name; I think PGI is a lot more common than pgi, so can we change this (along with the easyconfig filename)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reasoning was as follows (see the comment thread for the easyblock)

The compiler itself ships with a sample modulefile named "pgi/15.7", so people are used to loading modulefiles for this compiler with the non-capitalized pgi (you can do a google search for "pgi module" and see what other sites use).

On the other hand this also seems to go with an all-lowercase convention that many HPC sites but evidently not easybuild use.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have full control over module names in EasyBuild, so using the official name PGI here doesn't mean you can't obtain a module named pgi/.... It does mean you'll get PGI/... by default though, that's true.

A quick look at http://www.pgroup.com/ makes it clear to me that PGI is the official name; pgi is not mentioned at all on the main page (I didn't look beyond that).

Personally, I'm not convinced that going with pgi here because most sites seem to use pgi as a module name is a good reason to diverge from our policy of using 'official' software names in easyconfig files, especially since eb supports using a custom module naming scheme to consistently make all of your modules lowercase if you want to.
But, I don't want to turn this into a bikeshedding discussion either...

@rjeschmi: thoughts?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pgi themselves distribute modulefiles and I think they have the
lowercase name. (Away from my computer right now)

So in that sense the official name is what they use there.

On Sun, Sep 13, 2015, 4:21 AM Kenneth Hoste [email protected]
wrote:

In easybuild/easyconfigs/p/pgi/pgi-15.7-GNU-4.9.2-2.25.eb
#1833 (comment)
:

@@ -0,0 +1,22 @@
+name = 'pgi'

You have full control over module names in EasyBuild, so using the
official name PGI here doesn't mean you can't obtain a module named
pgi/.... It does mean you'll get PGI/... by default though, that's true.

A quick look at http://www.pgroup.com/ makes it clear to me that PGI is
the official name; pgi is not mentioned at all on the main page (I didn't
look beyond that).

Personally, I'm not convinced that going with pgi here because most sites
seem to use pgi as a module name is a good reason to diverge from our
policy of using 'official' software names in easyconfig files, especially
since eb supports using a custom module naming scheme to consistently
make all of your modules lowercase if you want to.
But, I don't want to turn this into a bikeshedding discussion either...

@rjeschmi https://github.com/rjeschmi: thoughts?


Reply to this email directly or view it on GitHub
https://github.com/hpcugent/easybuild-easyconfigs/pull/1833/files#r39345616
.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjeschmi: not 100% sure what you mean, but I think the answer is no (currently). I do see a use for it though, e.g.:

name = 'hanythingondemand'
...
module_name = 'hod'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjeschmi: support for overriding the name bit of the module name is implemented in easybuilders/easybuild-framework#1389 (still WIP)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with using PGI internally everywhere, but leaving the option open to use a "pgi" lowercase modulename, as the PGI compiler supplies itself.

I am in a bit of a crunch now trying to get our easybuild structure usable by users for testing (see my list email to come about lmod lua files) -- I will have more time next week if that is ok.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option is always there to make EB name the module any way you want, the question is just whether having it produce a module named PGI/... by default is OK...

In my view, lowercase module names (for specific modules, or all modules) is a site-specific policy.

The default policy we maintain in EB is to use the 'official' software name (i.e., the one most prevalent on the homepage), but it's not limiting in any way since we support custom module naming schemes.

I'm not sure which Lmod/Lua issue you're referring to. EasyBuild or Lmod mailing list?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W.r.t. timing: no pressure there, we still have loads of time to get PGI support included for the next EB release (planned for end of Oct'15).

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 7, 2015

Jenkins: ok to test

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3884/
Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3884/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@bartoldeman
Copy link
Copy Markdown
Contributor Author

Actually the year is related to the major version number, see:
http://www.pgroup.com/support/download_releases.php
so one can just use 20%(version_major)s-%(version_major)s%(version_minor)s
The tarball does not have a . at 15.7, so I had to use %(version_major)s%(version_minor)s

@bartoldeman
Copy link
Copy Markdown
Contributor Author

I also changed the toolchain version from 'dummy' to '' so that the GCC module is loaded and its libraries are then picked up by the makelocalrc script.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3892/
Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3892/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4294/
Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4294/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4295/
Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4295/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4305/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4306/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 12, 2015

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/b9917b69ec14d3d91565 for a full test report.

@boegel boegel added this to the v2.4.0 milestone Sep 13, 2015
@boegel boegel modified the milestones: v2.4.0, v2.5.0 Nov 9, 2015
@boegel boegel modified the milestones: v2.5.0, v2.6.0 Dec 14, 2015
@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5766/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5767/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 23, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/47c405c2bde5d19c5e82 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 23, 2016

Jenkins: test this please

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5791/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 23, 2016

Retested on top of easybuilders/easybuild-easyblocks#658, good to go.

Thanks for looking into this @bartoldeman!

boegel added a commit that referenced this pull request Jan 23, 2016
Add easyconfig for PGI 15.7 using GCC 4.9.2 libraries.
@boegel boegel merged commit 060875f into easybuilders:develop Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants