Add easyconfig for PGI 15.7 using GCC 4.9.2 libraries.#1833
Add easyconfig for PGI 15.7 using GCC 4.9.2 libraries.#1833boegel merged 4 commits intoeasybuilders:developfrom
Conversation
|
Automatic reply from Jenkins: Can I test this? |
There was a problem hiding this comment.
@bartoldeman: we try to stick to the 'official' software name; I think PGI is a lot more common than pgi, so can we change this (along with the easyconfig filename)?
There was a problem hiding this comment.
My reasoning was as follows (see the comment thread for the easyblock)
The compiler itself ships with a sample modulefile named "pgi/15.7", so people are used to loading modulefiles for this compiler with the non-capitalized pgi (you can do a google search for "pgi module" and see what other sites use).
On the other hand this also seems to go with an all-lowercase convention that many HPC sites but evidently not easybuild use.
There was a problem hiding this comment.
You have full control over module names in EasyBuild, so using the official name PGI here doesn't mean you can't obtain a module named pgi/.... It does mean you'll get PGI/... by default though, that's true.
A quick look at http://www.pgroup.com/ makes it clear to me that PGI is the official name; pgi is not mentioned at all on the main page (I didn't look beyond that).
Personally, I'm not convinced that going with pgi here because most sites seem to use pgi as a module name is a good reason to diverge from our policy of using 'official' software names in easyconfig files, especially since eb supports using a custom module naming scheme to consistently make all of your modules lowercase if you want to.
But, I don't want to turn this into a bikeshedding discussion either...
@rjeschmi: thoughts?
There was a problem hiding this comment.
I think pgi themselves distribute modulefiles and I think they have the
lowercase name. (Away from my computer right now)
So in that sense the official name is what they use there.
On Sun, Sep 13, 2015, 4:21 AM Kenneth Hoste [email protected]
wrote:
In easybuild/easyconfigs/p/pgi/pgi-15.7-GNU-4.9.2-2.25.eb
#1833 (comment)
:@@ -0,0 +1,22 @@
+name = 'pgi'You have full control over module names in EasyBuild, so using the
official name PGI here doesn't mean you can't obtain a module named
pgi/.... It does mean you'll get PGI/... by default though, that's true.A quick look at http://www.pgroup.com/ makes it clear to me that PGI is
the official name; pgi is not mentioned at all on the main page (I didn't
look beyond that).Personally, I'm not convinced that going with pgi here because most sites
seem to use pgi as a module name is a good reason to diverge from our
policy of using 'official' software names in easyconfig files, especially
since eb supports using a custom module naming scheme to consistently
make all of your modules lowercase if you want to.
But, I don't want to turn this into a bikeshedding discussion either...@rjeschmi https://github.com/rjeschmi: thoughts?
—
Reply to this email directly or view it on GitHub
https://github.com/hpcugent/easybuild-easyconfigs/pull/1833/files#r39345616
.
There was a problem hiding this comment.
@rjeschmi: not 100% sure what you mean, but I think the answer is no (currently). I do see a use for it though, e.g.:
name = 'hanythingondemand'
...
module_name = 'hod'
There was a problem hiding this comment.
@rjeschmi: support for overriding the name bit of the module name is implemented in easybuilders/easybuild-framework#1389 (still WIP)
There was a problem hiding this comment.
I am happy with using PGI internally everywhere, but leaving the option open to use a "pgi" lowercase modulename, as the PGI compiler supplies itself.
I am in a bit of a crunch now trying to get our easybuild structure usable by users for testing (see my list email to come about lmod lua files) -- I will have more time next week if that is ok.
There was a problem hiding this comment.
The option is always there to make EB name the module any way you want, the question is just whether having it produce a module named PGI/... by default is OK...
In my view, lowercase module names (for specific modules, or all modules) is a site-specific policy.
The default policy we maintain in EB is to use the 'official' software name (i.e., the one most prevalent on the homepage), but it's not limiting in any way since we support custom module naming schemes.
I'm not sure which Lmod/Lua issue you're referring to. EasyBuild or Lmod mailing list?
There was a problem hiding this comment.
W.r.t. timing: no pressure there, we still have loads of time to get PGI support included for the next EB release (planned for end of Oct'15).
|
Jenkins: ok to test |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3884/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Actually the year is related to the major version number, see: |
|
I also changed the toolchain version from 'dummy' to '' so that the GCC module is loaded and its libraries are then picked up by the makelocalrc script. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3892/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4294/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4295/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4305/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4306/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5766/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5767/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
Jenkins: test this please |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5791/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Retested on top of easybuilders/easybuild-easyblocks#658, good to go. Thanks for looking into this @bartoldeman! |
Add easyconfig for PGI 15.7 using GCC 4.9.2 libraries.
See also easybuilders/easybuild-easyblocks#658 and easybuilders/easybuild-framework#1342