Skip to content

add support for specifying alternate name to be part of generated module name (REVIEW)#1389

Merged
boegel merged 4 commits intoeasybuilders:developfrom
boegel:modname
Oct 12, 2015
Merged

add support for specifying alternate name to be part of generated module name (REVIEW)#1389
boegel merged 4 commits intoeasybuilders:developfrom
boegel:modname

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 14, 2015

No description provided.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 14, 2015

@rjeschmi: please review (since this was your idea ;-))

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2041/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not very happy with this parameter name, since it's not clear this only covers part of the full module name (only the bit that is now covered by name)

maybe it should be name_in_module?

@rjeschmi, @wpoely86: suggestions?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem too bad. It is the "name" in the modulefile, so it is accurate.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use 'module name' in different places to refer to the whole thing, I'd like to make it crystal clear this is not the 'full' module name, just the software name part of it...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modmetaname?

IE it is the metadata for the module

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjeschmi: quoting you: "It is the "name" in the modulefile", so name_in_module is almost a one-to-one match?

'meta' is so... meta. ;-)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like _ It also makes the option reorder somewhere else alphabetically.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modaltsoftname ?

modaltappname ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like modaltsoftname: descriptive and long enough so you'll think twice before using it. @rjeschmi?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

On Tue, Sep 15, 2015, 3:53 PM Kenneth Hoste [email protected]
wrote:

In easybuild/framework/easyconfig/default.py
#1389 (comment)
:

 'modextrapaths': [{}, "Extra paths to be prepended in module file", MODULES],
 'modextravars': [{}, "Extra environment variables to be added to module file", MODULES],
 'modloadmsg': [{}, "Message that should be printed when generated module is loaded", MODULES],
 'modluafooter': ["", "Footer to include in generated module file (Lua syntax)", MODULES],
  • 'modname': [None, "Module name to use (rather than using software name", MODULES],

I like modaltsoftname: descriptive and long enough so you'll think twice
before using it. @rjeschmi https://github.com/rjeschmi?


Reply to this email directly or view it on GitHub
https://github.com/hpcugent/easybuild-framework/pull/1389/files#r39556436
.

@rjeschmi
Copy link
Copy Markdown
Contributor

looks fine

@boegel boegel changed the title add support for specifying alternate name to be part of generated module name (WIP) add support for specifying alternate name to be part of generated module name (REVIEW) Oct 12, 2015
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 12, 2015

updated to modaltsoftname, seems to work as expected so will merge as soon as Jenkins gives a green light

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2179/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2180/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 12, 2015

Going in, thanks for the review @rjeschmi!

boegel added a commit that referenced this pull request Oct 12, 2015
add support for specifying alternate name to be part of generated module name (REVIEW)
@boegel boegel merged commit 59e1429 into easybuilders:develop Oct 12, 2015
@boegel boegel deleted the modname branch October 12, 2015 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants