add support for specifying alternate name to be part of generated module name (REVIEW)#1389
add support for specifying alternate name to be part of generated module name (REVIEW)#1389boegel merged 4 commits intoeasybuilders:developfrom
Conversation
|
@rjeschmi: please review (since this was your idea ;-)) |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2041/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
It doesn't seem too bad. It is the "name" in the modulefile, so it is accurate.
There was a problem hiding this comment.
we use 'module name' in different places to refer to the whole thing, I'd like to make it crystal clear this is not the 'full' module name, just the software name part of it...
There was a problem hiding this comment.
modmetaname?
IE it is the metadata for the module
There was a problem hiding this comment.
@rjeschmi: quoting you: "It is the "name" in the modulefile", so name_in_module is almost a one-to-one match?
'meta' is so... meta. ;-)
There was a problem hiding this comment.
I don't like _ It also makes the option reorder somewhere else alphabetically.
There was a problem hiding this comment.
modaltsoftname ?
modaltappname ?
There was a problem hiding this comment.
I like modaltsoftname: descriptive and long enough so you'll think twice before using it. @rjeschmi?
There was a problem hiding this comment.
Sounds good
On Tue, Sep 15, 2015, 3:53 PM Kenneth Hoste [email protected]
wrote:
In easybuild/framework/easyconfig/default.py
#1389 (comment)
:'modextrapaths': [{}, "Extra paths to be prepended in module file", MODULES], 'modextravars': [{}, "Extra environment variables to be added to module file", MODULES], 'modloadmsg': [{}, "Message that should be printed when generated module is loaded", MODULES], 'modluafooter': ["", "Footer to include in generated module file (Lua syntax)", MODULES],
- 'modname': [None, "Module name to use (rather than using software name", MODULES],
I like modaltsoftname: descriptive and long enough so you'll think twice
before using it. @rjeschmi https://github.com/rjeschmi?—
Reply to this email directly or view it on GitHub
https://github.com/hpcugent/easybuild-framework/pull/1389/files#r39556436
.
|
looks fine |
|
updated to |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2179/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2180/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Going in, thanks for the review @rjeschmi! |
add support for specifying alternate name to be part of generated module name (REVIEW)
No description provided.