put dummy template values in place to make comparison with dumped easyconfig more robust#1835
Merged
boegel merged 1 commit intoeasybuilders:developfrom Aug 7, 2015
Merged
Conversation
…yconfig more robust
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Member
Author
|
I'm merging this since it's pretty trivial, and currently blocking me from making progress. @rjeschmi: let me know if you have any remarks on this |
boegel
added a commit
that referenced
this pull request
Aug 7, 2015
put dummy template values in place to make comparison with dumped easyconfig more robust
Contributor
|
Looks fine It does seem arbitrary to replace the last instance with (name)s and not the source file instance, but it is arbitrary I guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required once easybuilders/easybuild-framework#1345 is merged to make the dump aspect of the easyconfig unit tests pass, unless more easyconfigs are tweaked to use templates like
%(name)sand/or%(namelower)s.For easyconfigs using the
CmdCpeasyblock, it's a bit more tricky since there additional templates (%(source)sand%(target)s) are supported by theCmdCpeasyblock itself, which get in the way when trying to resolve templates (since they're not defined (yet) after just parsing the easyconfig).That's not too big of an issue, it just means that the unit tests are a bit strict w.r.t. template values for these easyconfigs, and may require that templates like
%(name)sis used (where applicable) in strings where%(source)sand/or%(target)sare used as well.A couple of easyconfigs using
CmdCpare tweaked to deal with this.