Skip to content

enhance dump() to reformat dumped easyconfig according to style guidelines + refactoring#1345

Merged
boegel merged 23 commits intoeasybuilders:developfrom
boegel:dump-formatting
Aug 7, 2015
Merged

enhance dump() to reformat dumped easyconfig according to style guidelines + refactoring#1345
boegel merged 23 commits intoeasybuilders:developfrom
boegel:dump-formatting

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 7, 2015

wrapper PR for #1330 by @Caylo (I'm taking over ownership of that PR since her summer internship ended today)

only a couple of minor tweaks on top

Caylo and others added 22 commits July 28, 2015 15:05
@Caylo
begin dump formatting
bd575d4
@Caylo
dump formatting and inline comments
6be0295
@Caylo
style fixes
2ebee7a
@Caylo
private methods + split formatting and templating
de35868
@boegel
Merge branch 'develop' into dump-formatting
eb3c822
@Caylo
Merge pull request #8 from boegel/dump-formatting
f7d5ed2 
sync with develop & resolve conflicts
@boegel
move support for dumping easyconfig in format v1 to easyconfig/format…
b0ced05 
…/one.py + some refactoring
@boegel
use copy() method rather than copy.deepcopy on EasyConfig instances
3836140
@boegel
make reformatting of dumped easyconfigs with autopep8 optional, add u…
702a923 
…nit test
@boegel
move extract_comments to format/one.py
dc8ee7a
@boegel
rework _reformat_line method (was _format)
89d2c78
@boegel
simplify _reformat_line, fix FIXME w.r.t. recognizing parameter defin…
1a5be3c 
…ition line
@boegel
only reformat long lines
b04d9ad
@boegel
restore toolchain regexin tweak_one
6afadc0
@Caylo
Merge pull request #9 from boegel/dump-formatting
a6824d8 
move enhanced support for dumping easyconfig reformatted to format/one.py
@boegel
moar minor style fixes
f4d671b
@Caylo
Merge pull request #10 from boegel/dump-formatting
cf43c0d 
moar minor style fixes
@boegel
Merge branch 'develop' into dump-formatting
bfd5546
@Caylo
Merge pull request #12 from boegel/dump-formatting
c0666bf 
sync with develop
@Caylo
Merge pull request #14 from boegel/dump-formatting
50a556b 
redo major refactoring effort + moving things around
@boegel
Merge branch 'dump-formatting' of github.com:Caylo/easybuild-framewor…
6b38b00 
…k into dump-formatting
@boegel
extend docstring for extract_comments + use setdefault where applicable
460a07a
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 7, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1958/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1958/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel mentioned this pull request Aug 7, 2015
Open
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 7, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1960/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1960/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel mentioned this pull request Aug 7, 2015
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 7, 2015

Thanks a lot for all your work on this @Caylo! Going in...

boegel added a commit that referenced this pull request Aug 7, 2015
@boegel
Merge pull request #1345 from boegel/dump-formatting
d3276ba 
enhance dump() to reformat dumped easyconfig according to style guidelines + refactoring
@boegel boegel merged commit d3276ba into easybuilders:develop Aug 7, 2015
@boegel boegel deleted the dump-formatting branch August 7, 2015 23:02
@Flamefire Flamefire mentioned this pull request Apr 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @hpcugentbot @Caylo