{base}[GCCcore/12.2.0] git-annex v10.20230802 by jkuhl-uni · Pull Request #18673 · easybuilders/easybuild-easyconfigs

jkuhl-uni · 2023-08-29T07:35:54Z

Hi there, this is a module providing git-annex. This will be useful together with my other PRs

to build Datalad.

smoors

please fix formatting: don't use tabs, and 4 spaces per indent.

jkuhl-uni · 2023-09-01T11:49:56Z

Hi, I understand the error, I just want to raise the issue that easybuild 4.8.0 (at least on our cluster) does not seem to check this, which is why I was not aware of this problem.

jkuhl-uni · 2023-09-01T12:48:05Z

I think at least parts of the errors I am getting are coming from this.
@smoors can you tell me what is going on here?

Hi, I understand the error, I just want to raise the issue that easybuild 4.8.0 (at least on our cluster) does not seem to check this, which is why I was not aware of this problem.

jkuhl-uni · 2023-09-07T10:15:34Z

Hi @smoors,
could you have a look if this is ready to merge so I could proceed with #18645?
I would be more than greatful.

Co-authored-by: Sam Moors <[email protected]>

smoors · 2023-09-07T14:51:43Z

@boegelbot: please test @ generoso

boegelbot · 2023-09-07T14:55:09Z

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=18673 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18673 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 11663

Test results coming soon (I hope)...

Details

- notification for comment with ID 1710294803 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-09-07T14:55:35Z

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/1f5d6de9d72a4454495e58ef3180702c for a full test report.

jkuhl-uni · 2023-09-07T15:02:46Z

Okay, checksum does not match... I'll have a look again. I think I know what is going on, I think I forgiot the checkout of the correct tag when computing the given checksum.
Sorry about that

smoors · 2023-09-07T15:11:20Z

you don't have to manually insert the checksum, use eb <easyconfig> --force --inject-checksums

jkuhl-uni · 2023-09-07T15:19:11Z

Thanks, yes. I did that.

Co-authored-by: Sam Moors <[email protected]>

smoors · 2023-09-07T15:26:13Z

@boegelbot: please test @ generoso

boegelbot · 2023-09-07T15:30:09Z

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=18673 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18673 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 11664

Test results coming soon (I hope)...

Details

- notification for comment with ID 1710353486 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-09-07T15:58:55Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/32856e8b73bc24671d4009bb31c32d89 for a full test report.

smoors · 2023-09-11T15:14:14Z

@boegelbot please test @ jsc-zen2

boegelbot · 2023-09-11T15:15:08Z

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18673 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18673 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 3358

Test results coming soon (I hope)...

Details

- notification for comment with ID 1714093266 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-09-11T15:36:20Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/1262fb986d0a1e0b3751ae6b3ba81284 for a full test report.

smoors

lgtm

smoors · 2023-09-11T15:47:55Z

Going in, thanks @jkuhl-uni!

adding easyconfigs: git-annex-10.20230802-GCCcore-12.2.0.eb

f242db7

jkuhl-uni mentioned this pull request Aug 29, 2023

{tools}[GCCcore/12.2.0] datalad v0.18.4 #18675

Merged

smoors changed the title ~~adding easyconfigs: git-annex-10.20230802-GCCcore-12.2.0.eb~~ {base}[GCCcore/12.2.0] git-annex v10.20230802 Sep 1, 2023

smoors reviewed Sep 1, 2023

View reviewed changes

jkuhl-uni added 3 commits September 1, 2023 10:12

fixed formatting

d13ad70

pep8 compliance

ee7e8ed

added checksum

b13d500

jkuhl-uni added 2 commits September 1, 2023 12:04

commata in sources

9537b48

fixed checksum

f1829b2

jkuhl-uni added 3 commits September 5, 2023 12:45

sort checksums out of source dict

42be5c8

fix small flake8 issue

001d2c3

delete line

70044b1

easybuilders deleted a comment from boegelbot Sep 7, 2023

smoors added the new label Sep 7, 2023

smoors reviewed Sep 7, 2023

View reviewed changes

Comment thread easybuild/easyconfigs/g/git-annex/git-annex-10.20230802-GCCcore-12.2.0.eb Outdated

fix build opts

67f4a4e

Co-authored-by: Sam Moors <[email protected]>

added checksum with eb inject

13e24d1

smoors reviewed Sep 7, 2023

View reviewed changes

Comment thread easybuild/easyconfigs/g/git-annex/git-annex-10.20230802-GCCcore-12.2.0.eb Outdated

None checksums

f71065d

Co-authored-by: Sam Moors <[email protected]>

smoors added this to the next release (4.8.2?) milestone Sep 11, 2023

smoors approved these changes Sep 11, 2023

View reviewed changes

smoors merged commit f6cf9da into easybuilders:develop Sep 11, 2023

jkuhl-uni deleted the 20230829093329_new_pr_git-annex1020230802 branch September 21, 2023 12:22

Conversation

jkuhl-uni commented Aug 29, 2023 • edited by smoors Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smoors left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkuhl-uni commented Sep 1, 2023

Uh oh!

jkuhl-uni commented Sep 1, 2023

Uh oh!

jkuhl-uni commented Sep 7, 2023

Uh oh!

Uh oh!

smoors commented Sep 7, 2023

Uh oh!

boegelbot commented Sep 7, 2023

Uh oh!

boegelbot commented Sep 7, 2023

Uh oh!

jkuhl-uni commented Sep 7, 2023

Uh oh!

smoors commented Sep 7, 2023

Uh oh!

jkuhl-uni commented Sep 7, 2023

Uh oh!

Uh oh!

smoors commented Sep 7, 2023

Uh oh!

boegelbot commented Sep 7, 2023

Uh oh!

boegelbot commented Sep 7, 2023

Uh oh!

smoors commented Sep 11, 2023

Uh oh!

boegelbot commented Sep 11, 2023

Uh oh!

boegelbot commented Sep 11, 2023

Uh oh!

smoors left a comment

Choose a reason for hiding this comment

Uh oh!

smoors commented Sep 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jkuhl-uni commented Aug 29, 2023 •

edited by smoors

Loading