fix post-install command for SuperLU_DIST in case library prefix is lib instead of lib64 by casparvl · Pull Request #20162 · easybuilders/easybuild-easyconfigs

casparvl · 2024-03-20T13:38:19Z

(created using eb --new-pr)

SuperLU_DIST currently has the following postinstallcmds:

postinstallcmds = [
    "rm %(installdir)s/lib64/libsuperlu.a",  # remove broken symlink to libsuperlu.a
]

However, on my system, this leads to a failure: the SuperLU_DIST libraries are installed in %(installdir)s/lib instead of %(installdir)s/lib64. Thus, the rm fails since the directory doesn't exist.

Proposed solution:

# remove broken symlink to libsuperlu.a
postinstallcmds = [
    "if[ -f %(installdir)s/lib64/libsuperlu.a ]; then rm %(installdir)s/lib64/libsuperlu.a; fi",
    "if[ -f %(installdir)s/lib/libsuperlu.a ]; then rm %(installdir)s/lib/libsuperlu.a; fi"
]

This should be safe for everyone :) And everyone will need it if we merge easybuilders/easybuild-easyblocks#3227

casparvl · 2024-03-20T13:39:18Z

@boegelbot please test @ generoso

boegelbot · 2024-03-20T13:40:06Z

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=20162 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20162 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 13150

Test results coming soon (I hope)...

Details

- notification for comment with ID 2009590625 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2024-03-20T13:42:48Z

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/1d95d59a07db49a694bcf4e35562f017 for a full test report.

casparvl · 2024-03-20T13:58:20Z

@boegelbot please test @ generoso

boegelbot · 2024-03-20T14:00:05Z

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=20162 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20162 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 13152

Test results coming soon (I hope)...

Details

- notification for comment with ID 2009638077 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

casparvl · 2024-03-20T14:03:51Z

Test report by @casparvl
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/30c473d704f2cd5061d4bed58fc3aec8 for a full test report.

boegelbot · 2024-03-20T14:04:47Z

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c4b719c035983495ecaea367b8353891 for a full test report.

casparvl · 2024-03-20T14:06:36Z

@boegelbot please test @ jsc-zen3

boegelbot · 2024-03-20T14:10:10Z

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20162 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20162 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 3813

Test results coming soon (I hope)...

Details

- notification for comment with ID 2009658790 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2024-03-20T14:12:49Z

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/12904e2e24070ba2c2b571c03d1ac722 for a full test report.

smoors · 2024-03-21T12:49:22Z

should not be needed if you apply easybuilders/easybuild-framework#4435

… released

casparvl · 2024-03-21T13:25:46Z

@boegelbot please test @ jsc-zen3

boegelbot · 2024-03-21T13:30:08Z

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20162 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20162 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 3825

Test results coming soon (I hope)...

Details

- notification for comment with ID 2012290717 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2024-03-21T13:32:38Z

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/6d747cade548d6855e2efc6982e16cd6 for a full test report.

smoors

lgtm

smoors · 2024-03-21T13:55:51Z

Going in, thanks @casparvl!

Fix issue in case library prefix is lib instead of lib64

da2b197

casparvl changed the title ~~Fix issue in case library prefix is lib instead of lib64~~ SuperLU_DIST fix issue in case library prefix is lib instead of lib64 Mar 20, 2024

casparvl marked this pull request as draft March 20, 2024 13:45

casparl added 2 commits March 20, 2024 14:46

fix 2023a version for SuperLU

ab56cde

Fix missing space

3818128

easybuilders deleted a comment from boegelbot Mar 20, 2024

casparvl marked this pull request as ready for review March 20, 2024 15:48

casparvl added the bug fix label Mar 21, 2024

Add comment so that we remember we can strip it once EasyBuild 5.0 is…

69d070f

… released

smoors added this to the release after 4.9.0 milestone Mar 21, 2024

smoors approved these changes Mar 21, 2024

View reviewed changes

smoors merged commit e9566be into easybuilders:develop Mar 21, 2024

boegel changed the title ~~SuperLU_DIST fix issue in case library prefix is lib instead of lib64~~ fix post-install command for SuperLU_DIST in case library prefix is lib instead of lib64 Mar 27, 2024

Conversation

casparvl commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

casparvl commented Mar 20, 2024

Uh oh!

boegelbot commented Mar 20, 2024

Uh oh!

boegelbot commented Mar 20, 2024

Uh oh!

casparvl commented Mar 20, 2024

Uh oh!

boegelbot commented Mar 20, 2024

Uh oh!

casparvl commented Mar 20, 2024

Uh oh!

boegelbot commented Mar 20, 2024

Uh oh!

casparvl commented Mar 20, 2024

Uh oh!

boegelbot commented Mar 20, 2024

Uh oh!

boegelbot commented Mar 20, 2024

Uh oh!

smoors commented Mar 21, 2024

Uh oh!

casparvl commented Mar 21, 2024

Uh oh!

boegelbot commented Mar 21, 2024

Uh oh!

boegelbot commented Mar 21, 2024

Uh oh!

smoors left a comment

Choose a reason for hiding this comment

Uh oh!

smoors commented Mar 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

casparvl commented Mar 20, 2024 •

edited

Loading