Skip to content

create lib -> lib64 symlink (or vice versa) *before* running postinstallcmds#4435

Merged
boegel merged 2 commits into5.0.xfrom
ocaisa-patch-1
Feb 8, 2024
Merged

create lib -> lib64 symlink (or vice versa) *before* running postinstallcmds#4435
boegel merged 2 commits into5.0.xfrom
ocaisa-patch-1

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Jan 9, 2024

Not having the symlinks in place means that postinstallcmds that rely on using/modifying something in the library directory have to use tricks to figure out the correct location.

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Jan 9, 2024

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 9, 2024

this will require fixing Brunsli easyconfigs due to lib* wildcard:

postinstallcmds = [ 
    "mkdir %(installdir)s/bin",
    "cp dbrunsli %(installdir)s/bin/",
    "cp libbrunsli*.a %(installdir)s/lib*/",
    "cp libbrunsli*.%s %%(installdir)s/lib*/" % SHLIB_EXT,
]

@ocaisa ocaisa changed the base branch from develop to 5.0.x January 9, 2024 17:17
@ocaisa ocaisa changed the base branch from 5.0.x to develop January 9, 2024 17:20
@boegel boegel added change EasyBuild-5.0 EasyBuild 5.0 labels Jan 15, 2024
@boegel boegel added this to the 5.0 milestone Jan 15, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 15, 2024

@ocaisa This is a "breaking" change, so I'm re-targeting this to EasyBuild 5.0

@smoors You're right... How did you find that particular easyconfig? Any others that may be hit by this?

@boegel boegel changed the base branch from develop to 5.0.x January 15, 2024 09:34
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 15, 2024

@smoors You're right... How did you find that particular easyconfig? Any others that may be hit by this?

quick and dirty regex search on lib* after postinstallcmds. did not see any other issues, but may have missed some.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 7, 2024

@smoors You're right... How did you find that particular easyconfig? Any others that may be hit by this?

quick and dirty regex search on lib* after postinstallcmds. did not see any other issues, but may have missed some.

Brunsli is the only case I can find, and there we can make sure it works regardless of the order of lib/lib64 symlinks vs postinstallcmds by specifying -DCMAKE_INSTALL_LIBDIR=lib so stuff never ends up in <prefix>/lib64 (before we symlink), see:

@easybuilders easybuilders deleted a comment from boegelbot Feb 7, 2024
@boegel boegel changed the title Create lib/lib64 symlink before running postinstallcmds create lib -> lib64 symlink (or vice versa) *before* running postinstallcmds Feb 7, 2024
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants